Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <591b050483a0326bbcaf075254a69bfefc77550f.camel@kernel.org>
Subject: Re: [PATCH] fs/ceph:fix speical error code in ceph_try_get_caps()
From:   Jeff Layton <jlayton@kernel.org>
To:     Wu Bo <wubo40@huawei.com>, sage@redhat.com, idryomov@gmail.com
Cc:     ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
        liuzhiqiang26@huawei.com, linfeilong@huawei.com
Date:   Wed, 29 Apr 2020 11:37:25 -0400
In-Reply-To: <1588125715-188363-1-git-send-email-wubo40@huawei.com>
References: <1588125715-188363-1-git-send-email-wubo40@huawei.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.1 (3.36.1-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2020-04-29 at 10:01 +0800, Wu Bo wrote:
> There are 3 speical error codes: -EAGAIN/-EFBIG/-ESTALE.
> After call try_get_cap_refs function, judge the same 
> error code -EAGAIN twice. So corrected the error code of judgment 
> from -EAGAIN to -ESTAE.
> 
> Signed-off-by: Wu Bo <wubo40@huawei.com>
> ---
>  fs/ceph/caps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
> index 185db76..1a8e20e 100644
> --- a/fs/ceph/caps.c
> +++ b/fs/ceph/caps.c
> @@ -2749,7 +2749,7 @@ int ceph_try_get_caps(struct inode *inode, int need, int want,
>  
>  	ret = try_get_cap_refs(inode, need, want, 0, flags, got);
>  	/* three special error codes */
> -	if (ret == -EAGAIN || ret == -EFBIG || ret == -EAGAIN)
> +	if (ret == -EAGAIN || ret == -EFBIG || ret == -ESTALE)
>  		ret = 0;
>  	return ret;
>  }

Good catch! Merged into testing branch.
-- 
Jeff Layton <jlayton@kernel.org>