Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp811188ybz; Wed, 29 Apr 2020 09:47:55 -0700 (PDT) X-Google-Smtp-Source: APiQypLCpWGAIkFHqbRbW0Ok1guK/obs1jgYN24AVvBnW6CAlBjZjNmNUxniCNyugaW/+Za6dgiS X-Received: by 2002:a50:e806:: with SMTP id e6mr3421039edn.153.1588178875596; Wed, 29 Apr 2020 09:47:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588178875; cv=none; d=google.com; s=arc-20160816; b=TzcFeZvFtWK+vuBiEb7SqFydz6pxTlTExuaXU4UM3f6Bbe7j7+WCBrQecErJgWDua+ toCnUkDTC5wnGn7T5cshae74NfB+Vcg+LON8gvZIGvbhtbgZAfC0O7PUrEr8KSY1KU7F lWWY2G3Numpb7Q1j7SXvZ8edJaTfTjSoNfaDHiiI7ZNY2HobwO5U5MbmxBiBGXzCwIn+ n8aQNOVrGeWvGovXFtv/xTccocQknRJjmpa9aJfqDa+OJ+rMOA+nekoe6yaPk8wwA0y7 6k7dOjYjZ384X54ZLCzXaqpQebb6QhhXxYRUOcK86vJlTr0DT23sjn9BpFn+OR3E86dr jTiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=DjB0zxN/rYdJsGDUbuJ0K8agsuXKLTVnAY/ujS64FRA=; b=gKd8LHIjkrkUZHBxXW8MSCgTJaYqqho/he8DKw+L7YzOPMeul4OffHKYG+QvbcqVGJ gny4L8KNEKRfd0wfLCHOfdWybZU3KctIfS0jOWX08t+Awsv3EWwAnKzoCx8USVrRz/n9 lOe1aH1jCeoKug1K33gvXr1gv7Js1UoGB21eWbpk1f9jeTejU62oZX89jY+o2slW7hot 8MEcX2i0/bj5UXXbzMqK/kmeUot+3EqhhGpbB03C1NsmFNk7d89v41cqt+9jeB5G1VOK yN4Xyer2zOiDNPdksRfv0mW/nWu/tMVtUnLAR1Eljwv4sFfXZymSrb9IhV/8DcPckNlh je7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a4si4449533edf.478.2020.04.29.09.47.32; Wed, 29 Apr 2020 09:47:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726853AbgD2QqJ (ORCPT + 99 others); Wed, 29 Apr 2020 12:46:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:56672 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726580AbgD2QqJ (ORCPT ); Wed, 29 Apr 2020 12:46:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BB1C4AC69; Wed, 29 Apr 2020 16:46:06 +0000 (UTC) Date: Wed, 29 Apr 2020 18:46:07 +0200 (CEST) From: Miroslav Benes To: Peter Zijlstra cc: jpoimboe@redhat.com, alexandre.chartre@oracle.com, linux-kernel@vger.kernel.org, jthierry@redhat.com, tglx@linutronix.de, x86@kernel.org Subject: Re: [PATCH v2 00/14] objtool vs retpoline In-Reply-To: <20200428191101.886208539@infradead.org> Message-ID: References: <20200428191101.886208539@infradead.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Apr 2020, Peter Zijlstra wrote: > Hi, > > Based on Alexandre's patches, here's a few that go on top of tip/objtool/core. > > With these patches on objtool can completely understand retpolines and RSB > stuffing, which means it can emit valid ORC unwind information for them, which > in turn means we can now unwind through a retpoline. > > New since last time: > > - 1-3, alternatives vs ORC unwind > - 7-9: implement some suggestions from Julien > - addressed feedback You can add my Reviewed-by: Miroslav Benes to patches 1A, 1B and 2-10 (objtool patches and updated smap fix). The other four patches should be fine too, but I am not well versed in the speculation stuff. Miroslav