Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751142AbWCGRN3 (ORCPT ); Tue, 7 Mar 2006 12:13:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751320AbWCGRN3 (ORCPT ); Tue, 7 Mar 2006 12:13:29 -0500 Received: from smtp.osdl.org ([65.172.181.4]:7622 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751142AbWCGRN3 (ORCPT ); Tue, 7 Mar 2006 12:13:29 -0500 Date: Tue, 7 Mar 2006 09:12:59 -0800 (PST) From: Linus Torvalds To: Pekka J Enberg cc: Jesper Juhl , Linux Kernel Mailing List , Andrew Morton , markhe@nextd.demon.co.uk, Andrea Arcangeli , Mike Christie , James Bottomley , Jens Axboe Subject: Re: [PATCH] slab: fix offslab_limit in calculate_slab_order (Was: Slab corruption in 2.6.16-rc5-mm2) In-Reply-To: Message-ID: References: <200603060117.16484.jesper.juhl@gmail.com> <200603062136.17098.jesper.juhl@gmail.com> <9a8748490603061253u5e4d7561vd4e566f5798a5f4@mail.gmail.com> <9a8748490603061256h794c5af9wa6fbb616e8ddbd89@mail.gmail.com> <9a8748490603061354vaa53c72na161d26065b9302e@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 613 Lines: 19 On Tue, 7 Mar 2006, Pekka J Enberg wrote: > > No you're not, it's broken. However, I think you're forgetting to reset > cachep->num when we go over MAX_GFP_ORDER, no? No, we only ever set "cachep->num" for something that we've decided is valid. "gfporder" can never be > MAX_GFP_ORDER inside the loop, because we just iterate between 0..MAX_GFP_ORDER. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/