Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200429173112.38366-1-alcooperx@gmail.com> <20200429173112.38366-4-alcooperx@gmail.com>
In-Reply-To: <20200429173112.38366-4-alcooperx@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 29 Apr 2020 21:11:06 +0300
Message-ID: <CAHp75VdwCBDTpipJZFOXxEvB4yW1qZo5XC5vs1pzHfTnVR+Nvw@mail.gmail.com>
Subject: Re: [PATCH v4 3/4] usb: ehci: Add new EHCI driver for Broadcom STB SoC's
To:     Al Cooper <alcooperx@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        devicetree <devicetree@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        USB <linux-usb@vger.kernel.org>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Rob Herring <robh+dt@kernel.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 29, 2020 at 8:34 PM Al Cooper <alcooperx@gmail.com> wrote:
>
> Add a new EHCI driver for Broadcom STB SoC's. A new EHCI driver
> was created instead of adding support to the existing ehci platform
> driver because of the code required to workaround bugs in the EHCI
> controller.

...

> +/* Copyright (c) 2018, Broadcom */

2020?

...

> +       res_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +       hcd->regs = devm_ioremap_resource(dev, res_mem);

devm_platform_get_and_ioremap_resource() ?

> +       if (IS_ERR(hcd->regs)) {
> +               err = PTR_ERR(hcd->regs);
> +               goto err_clk;
> +       }
> +       hcd->rsrc_start = res_mem->start;
> +       hcd->rsrc_len = resource_size(res_mem);

-- 
With Best Regards,
Andy Shevchenko