Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp920900ybz; Wed, 29 Apr 2020 11:45:42 -0700 (PDT) X-Google-Smtp-Source: APiQypLyHrVmrqMuYMmskq9L7BphiTFmg587yZKBS0oWYnfVhpZfB8KfZ2A5l2y3T3egnuivmxQ8 X-Received: by 2002:a05:6402:2d5:: with SMTP id b21mr3633238edx.291.1588185941856; Wed, 29 Apr 2020 11:45:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588185941; cv=none; d=google.com; s=arc-20160816; b=krda3WZk9csLl9zpbbM8z1K+/EHeNueHciWW5h7To7TRqVvWKgBI8do857bNILl2O9 R5lUJGrjHVxColIeYXooHzMdxdiQYZCxg+gDQLkErl+Z/afC1iTfx6acsEwdIXYIyy2r ORN6goMpnTdImpTsYkJo01A0kSGz9y9d96MSFx9vAuEIp/NL2NeN1rFqFwKfzwAxPewE z/e4iJC1KQlgg1AZ+UXI4P13TnuuV4e0RGPsLXcYJbIoYXfYejf0v3diqB6iT/apOg7k QlkNh/QulxwZcDGZl8x5W1dSyxnrJWqT/2y/XnVGIiPhuuNEcTds/h0wlGoP5cBcdOT7 ZsQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=pxLRDiB6qwq222rDMPPzIuSG9TXNfVy3A7KnQ29Ftw4=; b=TT0CuM5RWlVBZDyjekHXYCKgqcsJlOqyzJGXDxcx8TNVtxJhyfvNQrJjY0Pr0yE/Rm dN0ia+biG8famK6FqBWZIHiL1910e6PVRbcPd+eaNre801fHokTW+L8JjTrzKluTH0z7 mWVx6iPZvuq/pFgjrGUN/vFtsMc2BPAYH6pT0Irc79wkqzMEzDGiGWJ0H8m9jj36WZmE 2dZVqMYlGeMJ3j/WSWL2uo6GfPK9UOy4u9TQVe6DSp8RyTloRuHOHfxCnaIY/OSAXlqo R95i5FkSYc/Cp4vpOmwQDKS5sBN7f3IQLFtSWf7b0Ye3ziMXGpnuLf5wUNg9bMM8Xmvq 4hqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i21si4401096ejh.256.2020.04.29.11.45.18; Wed, 29 Apr 2020 11:45:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727041AbgD2Sn3 (ORCPT + 99 others); Wed, 29 Apr 2020 14:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726456AbgD2Sn3 (ORCPT ); Wed, 29 Apr 2020 14:43:29 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 494C3C03C1AE; Wed, 29 Apr 2020 11:43:29 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 32A2A1210D904; Wed, 29 Apr 2020 11:43:28 -0700 (PDT) Date: Wed, 29 Apr 2020 11:43:27 -0700 (PDT) Message-Id: <20200429.114327.1585519928398105692.davem@davemloft.net> To: zou_wei@huawei.com Cc: aviad.krawczyk@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next v2] hinic: Use ARRAY_SIZE for nic_vf_cmd_msg_handler From: David Miller In-Reply-To: <1588133860-55722-1-git-send-email-zou_wei@huawei.com> References: <1588133860-55722-1-git-send-email-zou_wei@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 Apr 2020 11:43:28 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zou Wei Date: Wed, 29 Apr 2020 12:17:40 +0800 > fix coccinelle warning, use ARRAY_SIZE > > drivers/net/ethernet/huawei/hinic/hinic_sriov.c:713:43-44: WARNING: Use ARRAY_SIZE > > ---------- Please don't put this "-------" here. > diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c > index b24788e..af70cca 100644 > --- a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c > +++ b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c > @@ -704,17 +704,15 @@ int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd, void *buf_in, > struct hinic_hwdev *dev = hwdev; > struct hinic_func_to_io *nic_io; > struct hinic_pfhwdev *pfhwdev; > - u32 i, cmd_number; > + u32 i; > int err = 0; Please preserve the reverse christmas tree ordering of local variables.