Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kevin Hilman <khilman@baylibre.com>
To:     Christian Hewitt <christianshewitt@gmail.com>,
        Jerome Brunet <jbrunet@baylibre.com>
Cc:     Tim Lewis <elatllat@gmail.com>, mark.rutland@arm.com,
        devicetree@vger.kernel.org, joy.cho@hardkernel.com,
        narmstrong@baylibre.com, linux-kernel@vger.kernel.org,
        robh+dt@kernel.org, tobetter@gmail.com,
        linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4] arm64: dts: meson: S922X: extend cpu opp-points
In-Reply-To: <2A9D3FBA-917A-42C7-9757-4316D6B3D284@gmail.com>
References: <20200426162119.GA23268@imac> <1ja72x2t7w.fsf@starbuckisacylon.baylibre.com> <2A9D3FBA-917A-42C7-9757-4316D6B3D284@gmail.com>
Date:   Wed, 29 Apr 2020 11:54:53 -0700
Message-ID: <7hd07qktqa.fsf@baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Christian Hewitt <christianshewitt@gmail.com> writes:

>> On 27 Apr 2020, at 1:06 pm, Jerome Brunet <jbrunet@baylibre.com> wrote:
>>=20
>> On Sun 26 Apr 2020 at 18:21, Tim Lewis <elatllat@gmail.com> wrote:
>>=20
>>> Add extra cpu pop points to allow mild overclock on S922X. The opp
>>> points are found in Hardkernel N2 sources [1] and testing shows no
>>> obvious issues on other S922X devices. Thermal throttling should
>>> keep things in-check if needed.
>>=20
>> The Odroid-N2 has a massive heatsink mounted.
>> Do we have any idea if this applies (is safe) on any other S922x
>> device ?
>
> I=E2=80=99ve tested it on several S922X box devices that I have, and also=
 the
> original S922X version of the VIM3 - all have similar sized passive
> heatsinks about 20% the size of the N2 one. No obvious issues with
> Kodi software decoding to increase CPU usage. NB: The original patch
> submission was N2 specific and then reworked to apply to all S922X
> devices at Neil=E2=80=99s suggestion (after my TB and earlier comments).

Yes, we also have OPP lowering enabled by default (which I think Neil
mentioned earlier) so this should be safe (enough) to apply.

Queuing for v5.8,

Kevin