Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp932374ybz; Wed, 29 Apr 2020 11:59:21 -0700 (PDT) X-Google-Smtp-Source: APiQypKzNwY23fCBJbTbSlHT0gtzdKbirX/lBr/Q/jc+NpPKaPx06FGsl5mUIG7yBQ84Y4gSVMwC X-Received: by 2002:aa7:ce0f:: with SMTP id d15mr3686340edv.290.1588186761357; Wed, 29 Apr 2020 11:59:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588186761; cv=none; d=google.com; s=arc-20160816; b=V+ijCws7IxrB6rpqb1kTHfyGicRB3Wuh/J164cFZ2g8rVMH6tnzo/JOL3KATimP9dp X+lVhYRRaG3iRhQ/QoaRMmFCn0GYl3TPROsUWOJsP13SOjvNv5+J3xckukWUYLu/kDkk dbiluKRHB1/veMm3n6f3b+mBc6Ps1G8n3PoDbQgN/wTw9R6ZhHb0Gqy+JHiLLdGMaSvK re6HYWej4eFuzFIqwOPHNvZLvKio16+93Akltq3VlH8bAfkad6+NDt0GenrmzMWsy4Wm aUHtn3k72rNZW+CfIbB6wsEX3Ni+wyRJuf9CcyG+O1yh4USwluaEUyTp8D4BOxPwcKQA jjYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=1XO8rfDHlwtS16wDJ5T75rNG/VZNkW2spFnEvqK96ms=; b=KecvXinxXf+uPV1AXVI43n5SumujX0ZlemoOukcP+sWNt9C7Erfl9RgvrMKuhcseQE Oxsow61f8kokqG5qjHtMXknI8tfFbO7gyvKe6KFnW4FfWGAtNC7RpbhxBHb235gZIgUL oALQZsrH3xd1Ji4mMBl1L29+9cx6GNNoTuyBpH9cUQyYX2a7VU5HKErkwoEJ+rm/Nbb9 MfaTt0zDsWAZ0OY2mp86ELg2NVibNHWD+daCvyCBxSt6UWB6QU/hDZpMuUI7jX1WycAI /eVehC+S5EkH/nqbISfH8kgvzsiV6JLAflqMyLu+NFT/QKkJTJDaOwr5OGpg3lZNmfwU KPrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gj20si4086952ejb.48.2020.04.29.11.58.58; Wed, 29 Apr 2020 11:59:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726921AbgD2S5E (ORCPT + 99 others); Wed, 29 Apr 2020 14:57:04 -0400 Received: from smtprelay0019.hostedemail.com ([216.40.44.19]:33148 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726423AbgD2S5E (ORCPT ); Wed, 29 Apr 2020 14:57:04 -0400 X-Greylist: delayed 553 seconds by postgrey-1.27 at vger.kernel.org; Wed, 29 Apr 2020 14:57:03 EDT Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 4E9CB18224D66; Wed, 29 Apr 2020 18:57:03 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,,RULES_HIT:41:355:379:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1537:1566:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3867:3870:3871:3872:4321:5007:7903:10004:10400:10848:11232:11658:11914:12296:12297:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21212:21324:21451:21627:21660:30012:30054:30060:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: table47_5a912d5982623 X-Filterd-Recvd-Size: 1444 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Wed, 29 Apr 2020 18:57:02 +0000 (UTC) Message-ID: <3fa8fba37f9339adc993cdb7afc77ed0e063967d.camel@perches.com> Subject: Re: [PATCH 03/10] efi/x86: Use pr_efi_err for error messages From: Joe Perches To: Ard Biesheuvel Cc: Arvind Sankar , linux-efi , X86 ML , Linux Kernel Mailing List Date: Wed, 29 Apr 2020 11:57:01 -0700 In-Reply-To: References: <20200429174120.1497212-1-nivedita@alum.mit.edu> <20200429174120.1497212-5-nivedita@alum.mit.edu> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-04-29 at 20:49 +0200, Ard Biesheuvel wrote: > On Wed, 29 Apr 2020 at 20:47, Joe Perches wrote: > > Looking at code for efi_printk -> efi_char16_printk, > > it's somewhat difficult to see where the "output_string" > > function pointer is set. Any clue? > It is set by the firmware. Sure, where in the code though?