Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp935037ybz; Wed, 29 Apr 2020 12:01:54 -0700 (PDT) X-Google-Smtp-Source: APiQypJwlx+ciczE5ZXh7RQu4J5rlG5/CkI1LCzovJe6av5z2Dh8LXhBSjN7ydyYDZf+KRKZAgVm X-Received: by 2002:a05:6402:356:: with SMTP id r22mr4069940edw.3.1588186914217; Wed, 29 Apr 2020 12:01:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588186914; cv=none; d=google.com; s=arc-20160816; b=gXkVzqPBxxGCXWdW3BN70eYXCuLlO+V43k5tR3027nXgg66C4rOHzBctC/7lHVJweB 2Hf7yEWl2UqPv2Uv+4lWEcxQyZOlGSGGRmB+CyQeg7U3agbnPOo6swzrCi70gm2YB50u L4R/VMQS42OA0qtgWphaSrq3SRQW1mOq5k4tM3W9DLcKDiRVOOCKmJwdu1M2sHNUXni8 ERD2t8a5FDyN0fsaKd7xLygABuUmp6nkzPzbS7hTzutyYFCIGqECK4PzYQF8P4+S/JO0 m4HdIQZvvAQqsFexcsVC8teZWi4PdI9vXXfOM08J7tUHzQIAEmmkJG5rqW+YpF7AEpzv 1vTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=n2yYgJOJnr/1MW66zNhtbTSW4fmTDlpNMwSmgByioLg=; b=P4Ruy16vpx2lvFiLauTgYM7yv2RbI+GxgSJM62Ko6hnVt2bwt3FfWDWEq88FHSypOb 58itupowO315WkbRotABocbWw4v0EZbGnHWodKGSD4A3c+YFO2Z6o/TOtwL28ApPrzNR 0INo/EC4YOEZP31oYDuMuuw9O2KarJsN+K9/jnofw7RVDqhY8qwrC9Gg8TF4gKmEgW9E w7H+Q3Agh2d8AOVlsx8htN9Uj2npfVYFOha1gddUVrNfBAHWF5fZOmakr7y2RS9CddNc GSQcxdNrqlRvyYIj/v7AcJWyO0vw/WKpdierxFZxIa9+pAg4ils9psPAyApwmk+xmCIE f3FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CqWc7zHr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n20si4124521edq.397.2020.04.29.12.01.27; Wed, 29 Apr 2020 12:01:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CqWc7zHr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727104AbgD2S7n (ORCPT + 99 others); Wed, 29 Apr 2020 14:59:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:41886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726519AbgD2S7m (ORCPT ); Wed, 29 Apr 2020 14:59:42 -0400 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4678020B80; Wed, 29 Apr 2020 18:59:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588186782; bh=mCzgndZV9oSgYH3A5npWh8MPllIC/3Qa3Gd80PeFISk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=CqWc7zHruZXF9PobL6vlCmR2JVxmu1hSKnbyUeP/6FvwejRNOemqRKiWdGBjaCK1Y QLTjFAP9qDi3xbg6Dl4RFp2LVqEcN+w+oTHDzhY+niYQnunw9/5w0hXg6YBgLMth7S ic2HSGgf4n+gR6SfcGhfCu0imLrIlRNILWD2R9xY= Received: by mail-il1-f174.google.com with SMTP id w6so3544692ilg.1; Wed, 29 Apr 2020 11:59:42 -0700 (PDT) X-Gm-Message-State: AGi0Puba9cv/wpA1RGEcmQeAbJRBvnMeXyTVWFVWWFcHqwotOuXAnaBq 3xNWpWp59vKc0SabAq5yZS5vVdhdEVXs9x1MEZ4= X-Received: by 2002:a92:405:: with SMTP id 5mr31534493ile.279.1588186780730; Wed, 29 Apr 2020 11:59:40 -0700 (PDT) MIME-Version: 1.0 References: <20200429174120.1497212-1-nivedita@alum.mit.edu> <20200429174120.1497212-5-nivedita@alum.mit.edu> <3fa8fba37f9339adc993cdb7afc77ed0e063967d.camel@perches.com> In-Reply-To: <3fa8fba37f9339adc993cdb7afc77ed0e063967d.camel@perches.com> From: Ard Biesheuvel Date: Wed, 29 Apr 2020 20:59:29 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 03/10] efi/x86: Use pr_efi_err for error messages To: Joe Perches Cc: Arvind Sankar , linux-efi , X86 ML , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Apr 2020 at 20:57, Joe Perches wrote: > > On Wed, 2020-04-29 at 20:49 +0200, Ard Biesheuvel wrote: > > On Wed, 29 Apr 2020 at 20:47, Joe Perches wrote: > > > Looking at code for efi_printk -> efi_char16_printk, > > > it's somewhat difficult to see where the "output_string" > > > function pointer is set. Any clue? > > It is set by the firmware. > > Sure, where in the code though? > In which code? The firmware code?