Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp953731ybz; Wed, 29 Apr 2020 12:19:55 -0700 (PDT) X-Google-Smtp-Source: APiQypJ6j+Ry2U/87tdsEYSOCVNkXAQEvRgprXzvRuXKlKU4uv32NeDH7Z0w9/4sHGunbyE7d+1A X-Received: by 2002:a05:6402:1d38:: with SMTP id dh24mr4110244edb.9.1588187995287; Wed, 29 Apr 2020 12:19:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588187995; cv=none; d=google.com; s=arc-20160816; b=lp8toMSzSiOjMSB2G0dvCUp5txe7DSSBmT/fxmoY+3LXLHAr0wV0jdsPyy10qBxxgz 7TmFVRfqs0DEcRpbzW9hzwfLrV7MqPsA8vT/iJcEztEcGtLxKRYSiHCl5Dc05FPpgu/7 yW5WiOtA6un4F3g2ffg60qI/9IlLV+6HA4df1kh5YY7t/+5egULhQxIZNYsvJ+pamXUB RTCRy4ZcIhysYu0btk0VseY+uW0jo08e0PyMmbFEEDPAKOwn6ybMznAzwVwPiikU652J oYnDElVl6NjRtiX0k+LHDRUpzTv1ARINKtpvGFvul3vDvWPhILSG4/zbWqQ4L/tPnvNk tUWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:references:cc:to:from:subject:ironport-sdr :ironport-sdr; bh=E4E7s6e+420X2b/pywkZXvJ7GAQLRBuh+xCNTwQweIM=; b=QrUGpbxuu5mlSrJLWKLru2IiwJPl7HC7gbyIvmhIpdDBYVnWPdfA+m3mGFCYMpR00R wyj0gAOW+j1qVNNvmEvmsVNF5edyuyseBrjh/y5Bf7e8U60qnlD1Oi6KGnOCNyySTXKh KQih8xKsa6UhR6sETdSK8Vvbxa7ZdkkY8bA00WS45HKl3wHJKLnaGzsAHBpbOcTNwIgj VFlLswYTtR4YMnNYY/LIaJYnc/j2r5C417s33igvHxFoR1+qcU9s1+wJ0bPFV9M+kvDu uKUsxXuWlStAuDfsAJGlpaVB5cjJHTMoUiupztZ0+LQo1ajb7T1xST7bqjkrve2nRY73 H+zg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q26si4360928ejx.520.2020.04.29.12.19.31; Wed, 29 Apr 2020 12:19:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726862AbgD2TSI (ORCPT + 99 others); Wed, 29 Apr 2020 15:18:08 -0400 Received: from mga12.intel.com ([192.55.52.136]:12231 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726423AbgD2TSI (ORCPT ); Wed, 29 Apr 2020 15:18:08 -0400 IronPort-SDR: kcQUbN5Xkm5BJG6vH8vpDkvnvTj7lJiEcBlm8D0vuYlIiHm6NNWOJ69j8N17lHJdfVA8Y0NWYL eZVeAmev0/iA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 12:18:07 -0700 IronPort-SDR: 7vPssWPGR6O7D8z/qQkZ28HwUw2pSYxrPMVji9rt141u2HUxrtvo1eCHAXdvsUwzzTVW0rVwnB 3/PT8iFDTJbw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,333,1583222400"; d="scan'208";a="261526443" Received: from poovizhi-mobl1.amr.corp.intel.com (HELO [10.254.110.237]) ([10.254.110.237]) by orsmga006.jf.intel.com with ESMTP; 29 Apr 2020 12:18:06 -0700 Subject: AMD / Memory Protection Keys From: Dave Hansen To: Suravee Suthikulpanit , linux-kernel@vger.kernel.org, x86@kernel.org Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, jon.grimm@amd.com, Sebastian Andrzej Siewior , Thomas Lendacky References: <1575363688-36727-1-git-send-email-suravee.suthikulpanit@amd.com> <68bdd6f0-a229-433a-9234-303a3b02b092@amd.com> <4b20cff5-6e16-3599-4fc1-4f51d7c18d1d@intel.com> Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <178377ad-efd6-d473-e10d-2928c171437e@intel.com> Date: Wed, 29 Apr 2020 12:18:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <4b20cff5-6e16-3599-4fc1-4f51d7c18d1d@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The docs for AMD's implementation of protection keys showed up[1]. Welcome to the party! It all looks fine, except for this nugget: The MPK mechanism is ignored in the following cases: ... for pages marked in the paging structures as read-only (R/W=0) or as supervisor addresses (U/S=0) That R/W=0 would mean that you can't access-disable read-only pages, which seems a bit goofy. It's certainly a feature that I could imagine folks wanting to have. Read-only pages might happen in unexpected places for things like mmap(PROT_WRITE)'d files or even CoW pages after fork(). Is this an error in the docs? 1. https://www.amd.com/system/files/TechDocs/24593.pdf