Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751445AbWCGSCQ (ORCPT ); Tue, 7 Mar 2006 13:02:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751451AbWCGSCQ (ORCPT ); Tue, 7 Mar 2006 13:02:16 -0500 Received: from stat9.steeleye.com ([209.192.50.41]:64235 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S1751445AbWCGSCP (ORCPT ); Tue, 7 Mar 2006 13:02:15 -0500 Subject: Re: Slab corruption in 2.6.16-rc5-mm2 From: James Bottomley To: Linus Torvalds Cc: Mike Christie , Jesper Juhl , Andrew Morton , linux-kernel@vger.kernel.org, markhe@nextd.demon.co.uk, andrea@suse.de, axboe@suse.de, penberg@cs.helsinki.fi In-Reply-To: References: <200603060117.16484.jesper.juhl@gmail.com> <9a8748490603061253u5e4d7561vd4e566f5798a5f4@mail.gmail.com> <9a8748490603061256h794c5af9wa6fbb616e8ddbd89@mail.gmail.com> <9a8748490603061354vaa53c72na161d26065b9302e@mail.gmail.com> <9a8748490603061501r387291f0ha10e9e9fe3c9e060@mail.gmail.com> <20060306150612.51f48efa.akpm@osdl.org> <9a8748490603061524j616bf6b3i1b6ab5354bcfe1a9@mail.gmail.com> <440CFABF.5040403@cs.wisc.edu> Content-Type: text/plain Date: Tue, 07 Mar 2006 12:01:52 -0600 Message-Id: <1141754512.3239.41.camel@mulgrave.il.steeleye.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 634 Lines: 21 On Mon, 2006-03-06 at 19:20 -0800, Linus Torvalds wrote: > > should be added back I think. > > Good eyes. I bet that's it. Yes, well done. Do we have confirmation yet that reversing this fixes the bug? I think a full reversal is in order, since buffer is a quantity being written to, there's no point in zeroing it. [Note to self: must do better in checking janitors patches] James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/