Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp980178ybz; Wed, 29 Apr 2020 12:50:09 -0700 (PDT) X-Google-Smtp-Source: APiQypLgDLejYH48RlliAKyOxT1w7i2Uy507oSp6/lVu539bm9wuZpI71q6iUm5I4f/Tk8CY4i1b X-Received: by 2002:aa7:d344:: with SMTP id m4mr4143457edr.297.1588189808956; Wed, 29 Apr 2020 12:50:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588189808; cv=none; d=google.com; s=arc-20160816; b=ItdsnXZ9i8BgkaScIS3/mobyyCXPDlH+d6F7LdWxNQiRHjzibIWinZYFQTVOwCmOVS I29CZfsDhjBtJfhH3nmkUY9BoD7IWTeJqaRrMOJBH0iQOwJHRhXRCaXQk4FdBu9F+zND CG6uKkjoAuh1WsDN9KVnopRWfjYJT5yjNr2sKhfTzGq/er2uWyMNbJi6kj7i/FZ81OXg HZQomgj5H71K2+GynC9enNCFZy7szxNG7IjPMXKvCUYq1SEB1X4cPwkVSYD/w1g1d1v6 jUpUDZX6uW8Ev8phdjAnScGcle9PkcNyLaSl715VwqPgKK8j2Uy056/nZjecJTEmc5Qh 9KMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=32HKbsMGC2EICTFtPIb5kMl0Cxm790zMc52s6pRFk24=; b=ilEYeYn4Cs3TuZHGlrv9byLk1gp9YJfMLB7cBQvJCwuEXjeEVbD2kkYTTSg+8linHs dxbJSTRSMPj37B1f6em9WGiQwWL/MJhUqNt8a9i1EyGxnbY7uKRHMseGWieI/7raLyG2 dolhWvitokXayKB41ARsYNM4VCyJ9G34uXNlbkbb+NHXBEnvmhUvQxiFOeb+HOWa7Tl3 BFQ83Nvrw0CW2VkdoXzicbGXL1To/l5LdGwgC2oW+WdsyqGh71+Soqu9juUwaEwmxGCJ +KJnPwiiDuQvcUpqUExhOgBMQIVBb+W0RpIR3fPfV0wpDJY3s8PwXiHRMS3Qa6IAQBNN RiYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bN0B9f6i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i16si3831707eds.554.2020.04.29.12.49.46; Wed, 29 Apr 2020 12:50:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bN0B9f6i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727832AbgD2TrX (ORCPT + 99 others); Wed, 29 Apr 2020 15:47:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:48130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727811AbgD2TrP (ORCPT ); Wed, 29 Apr 2020 15:47:15 -0400 Received: from pobox.suse.cz (unknown [195.250.132.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EB36120BED; Wed, 29 Apr 2020 19:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588189635; bh=imdDb6SEe8egaE3DWtE90vcKygzMU7wmOuUhdRPk8zY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=bN0B9f6iw/MfZp7uh/2hFkPjkJeuedU1Yd0zv33xUVg/SOOcYKIQp+zIFOEQN1eEm sCeux0tPex7kTp7ewfQBWL/e5iN9qn9XlQSFYIvvdoVKzj0pbkIXTxa+iyvnLDeZve Sa0O882EPvX4uUtIWkaEYwJqN5NHmV0hKeIZhIDM= Date: Wed, 29 Apr 2020 21:47:12 +0200 (CEST) From: Jiri Kosina To: Arnd Bergmann cc: Benjamin Tissoires , Rishi Gupta , Linus Walleij , Bastien Nocera , Dmitry Torokhov , Wolfram Sang , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: mcp2221: add gpiolib dependency In-Reply-To: <20200428213035.3108649-1-arnd@arndb.de> Message-ID: References: <20200428213035.3108649-1-arnd@arndb.de> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Apr 2020, Arnd Bergmann wrote: > Without gpiolib, this driver fails to link: > > arm-linux-gnueabi-ld: drivers/hid/hid-mcp2221.o: in function `mcp2221_probe': > hid-mcp2221.c:(.text+0x1b0): undefined reference to `devm_gpiochip_add_data' > arm-linux-gnueabi-ld: drivers/hid/hid-mcp2221.o: in function `mcp_gpio_get': > hid-mcp2221.c:(.text+0x30c): undefined reference to `gpiochip_get_data' > > Fixes: 328de1c519c5 ("HID: mcp2221: add GPIO functionality support") > Signed-off-by: Arnd Bergmann Applied, thanks Arnd. -- Jiri Kosina SUSE Labs