Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp987480ybz; Wed, 29 Apr 2020 12:58:25 -0700 (PDT) X-Google-Smtp-Source: APiQypIAuJdJTDH7VaH907sHMvJVQWEnabm+JVBh7+x24Xr8j13dnJ4MWqMqU/YTWjol2eFtPbS6 X-Received: by 2002:a17:907:402f:: with SMTP id nr23mr4362682ejb.240.1588190305120; Wed, 29 Apr 2020 12:58:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588190305; cv=none; d=google.com; s=arc-20160816; b=TNtKnW7Etj4kaCMfU6eJfr4ys8U+J/IgRF+2kUQZPO4nhpMT925sZAFaBQNOPq9sO6 W5XDUJxRNi3/SRgGwW5YbSDtGEzJ4ForwQ2i26IUy0iPYEmtDiaAAPd/Gv3F+peUoJyN HWLXzT8/HUo77RM8HXywJX1YVTRzdSFU+0W2UNDRa2FyooUAPZ+dak7gEZL22nc0pMl8 iy9fXvrZMX5HXlGv42A8/bGyB3rbX4L7Syxpas/mH6zmWSkHuwqPBpoPhA6TGu7dVwmc vn6SfRhtRBszswkqD7Z5GFcdEdldoso4VirJPAeJ5hRQOklEAbVt/8lSLV1vdqR9f5rx awig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=POiU/3zVi3KdBGp40hxpc9qc+KsFESjUKyFeCVtGwzE=; b=mEWYLKj2LeF5bGd4j/iYvrZ4tGtSaplyETg90R4VfmM3kgkZnxD7OEFs1CU64cZRPW VwqAvyPirVDrYdg4jV/IEpv9KMbRR0hyY5qnWgoxFW44CGPUaCAr+/96PALFCa3xukWs ir3wQ2YwzS22Jq3beK4uafdlcQrW0lzgH1wtAwEe9q94HotTDj8XFlYpZkc4n/mVIpcf szjLrKsGh/3c1YOYLbP+IQB16uygqFHKprMVPYwKVc5P4/Wt74sxZK6pXf229MISQWEh F/5hnkzhH2A4HQ9iE4P9izj/Oadm3TvqEBDXneDZvG0an605ZrZkvoBtB/ycGd8Vpoki z3Aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=T+1y6B6i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m29si4079511eda.592.2020.04.29.12.58.01; Wed, 29 Apr 2020 12:58:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=T+1y6B6i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726893AbgD2Tyh (ORCPT + 99 others); Wed, 29 Apr 2020 15:54:37 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:50464 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726456AbgD2Tyg (ORCPT ); Wed, 29 Apr 2020 15:54:36 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03TJrJrx115545; Wed, 29 Apr 2020 19:54:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=POiU/3zVi3KdBGp40hxpc9qc+KsFESjUKyFeCVtGwzE=; b=T+1y6B6iV3nORHfXlzRuhGtcZZL1GKnGdRh6rDLtLEIg5xMxt1qiKmo/DGqxMrUC5WYE R9tDUkN45aRIr1izHMQ2x+d6MemU/qpour3GxfYfzazK7ro2MHsG8HIB22Zp3KRZBN0u NkeFrI+76hU03lIYaiC8goVBvWOshJ1LbHhT42M31ge/Hjsnv24gtE6wlHiTDhFrTlHK Qj6cNfk95rsyyDPYXV45s+3OmCxZ6jBTD94xzXOvql82MhJgBLDkMZijqa0pFGEb11xH Ih6R1vmEiZKtUmilqQQTzyOf1LfHcCG6ssIE5Te2HbT8wZaaSZU7y81YrRkxM4101d8a cw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 30p01nxbqh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Apr 2020 19:54:31 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03TJqjRA145613; Wed, 29 Apr 2020 19:54:31 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 30mxpksv80-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Apr 2020 19:54:31 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 03TJsS8k007688; Wed, 29 Apr 2020 19:54:28 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 Apr 2020 12:54:28 -0700 Date: Wed, 29 Apr 2020 22:54:02 +0300 From: Dan Carpenter To: Colin King Cc: Jack Wang , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: pm80xx: remove redundant assignments to status Message-ID: <20200429195402.GS2014@kadam> References: <20200429154055.286617-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429154055.286617-1-colin.king@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9606 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004290146 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9606 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 clxscore=1011 phishscore=0 mlxlogscore=999 adultscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004290146 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 29, 2020 at 04:40:55PM +0100, Colin King wrote: > From: Colin Ian King > > The variable status is being assigned with a value that is never read > hence the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Better to remove the "status" variable entirely. regards, dan carpenter