Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1249888ybz; Wed, 29 Apr 2020 18:06:18 -0700 (PDT) X-Google-Smtp-Source: APiQypJrcbx3f4Ji4g50QGoa2U4H1sN6u5JhUCy96XVttWw8pVUruAQVpA/IgfoxhIlEnlGe2FqM X-Received: by 2002:a05:6402:95e:: with SMTP id h30mr573178edz.117.1588208778419; Wed, 29 Apr 2020 18:06:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588208778; cv=none; d=google.com; s=arc-20160816; b=xIvQwDd9TTGRuILbFraJL73qWk26YSdr/kWQhO/rfqzgKRGn3dSJqxpPUyFeta3hMV HyPWJDXZvZs9pwUrq3dCdESDE/5P2ZB2wzBpTdiaodWUTSg+n6GwEp34V0q6I9wCw0GQ Im6IZdpKLUf0FhJpXx57oHZud0tDOsPiJfNuVRrj3ZvpBicnJPxEYzR6U8Fls6dC+Tk2 HW3oxTZ94B6UTxyFbEm/rEBlF5Z7Atx0fIJI8RQlkSAM5dnAJmMyCfnuwcIxG/Mqoa65 3fFL82cMs6LoiufIgVsJwgtvRjz5vdQcOK5lZqqaATrGS2bVS+Qs059Rr2SVdT9YTues ObmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=nHd4t1dxAGq6mLJOxoRUU+Fay7yLnL9/fA8P7+mfDpQ=; b=zacV26G9fSADbhtmB1Agc61u7AvLalqJgWmI/qqx9arrprAxouyU8/Zf936olAu6C0 Zvo9NzmKs/1l6Yif1e5orShA4JshHPMawh8jiYrr5WXc48NAZamsutO44/is6AsQX2B1 +ZH399ZyVF7ZTvlQdiip7RSlsYKVje0WXsrsLTSKDkl+H6UOLLxZfsflFDN5iGaHEJFS pMC5+VIBXobx8hQh9uakVKDVkEy+xOC2p8Mtpg1vVcGwYBPB6HjQZk34qedrTXKMvYpE 33ZCAlgb380g9gbET88v1l7G1mLM7Flz+4g6ohXARiFra1EAg7brXZar0tpkP4NswUgL yJ1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b="AgHK/cFg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n5si1835329ejd.88.2020.04.29.18.05.55; Wed, 29 Apr 2020 18:06:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b="AgHK/cFg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726357AbgD3BEd (ORCPT + 99 others); Wed, 29 Apr 2020 21:04:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726279AbgD3BEc (ORCPT ); Wed, 29 Apr 2020 21:04:32 -0400 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 291B5C035494 for ; Wed, 29 Apr 2020 18:04:32 -0700 (PDT) Received: by mail-qt1-x841.google.com with SMTP id e17so3660138qtp.7 for ; Wed, 29 Apr 2020 18:04:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=nHd4t1dxAGq6mLJOxoRUU+Fay7yLnL9/fA8P7+mfDpQ=; b=AgHK/cFgIOfkFmmQJ2HHgpg3mx5clBmVW8MSgmXFicJyCJ7uFPspAVHR0NEiw9NKoI gep34agHPjs5RuEmiYWHSn+KyGhnMiDOdm2q0JfUMqqaV/P6rJ0s1LLiTktKWnJPcD7L DV2ThlelvfRAnYXjfKYFJIjuY/jQ8d27bN7IBHRgXqNlQedc7yhrytKpevi+SzGJibw/ 7ZqEpkp+LVWoZ3Q+jRu0nFJJT24qXdvadNF23JNoMuP8+aI7uNU1szKkiw33VIDiKPLC klezXWYEPlNEOjtem1Ra/HmwgV5jOSGB5Vhp5i2dUuzwwaro53RAyZAesvGtOyahi1ht YsSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=nHd4t1dxAGq6mLJOxoRUU+Fay7yLnL9/fA8P7+mfDpQ=; b=T4hF/fNXqwuo1x0Fqd+D5og3GBj/XBFUhw4p+zba2AOcieksu5ubjYiobs6vTv1gvA kMFtdHVHeZ7gwFT9oBVnuXkAo7K7MGCu9nTLvHEhFWPznZpR3s5j/IPcKh/R6jG80s6p wPQnDtOhPmu8GNDN1Ez2azMgxrOZWirRnquv8i/tYLIZo54lz+UWzsmBaXcDbrW0tGRm DLQxhrxY3h630b11AsOgwnNj//9dnYqjNq7pAOZHb4Jp7UYh+kqsTAUeeTtu5eiBjTTf 2VZXmgJmtT3khLLeHmoy3YXoKxkborObkaVCdVpCGDTq5S+sUFSJkKNqzplBTp3Q1c1W SJLw== X-Gm-Message-State: AGi0PuZMlL3902vAW01byLCUXhPKw/dEuW2u9mfd+eovxMbbrbRzsjwK C8Jb0G4TC5qPS/R5BMvLP5HUn4TGjM/dMg== X-Received: by 2002:aed:3aa3:: with SMTP id o32mr1207048qte.364.1588208671328; Wed, 29 Apr 2020 18:04:31 -0700 (PDT) Received: from [192.168.1.153] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id h6sm739542qtd.79.2020.04.29.18.04.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Apr 2020 18:04:30 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [RFC PATCH] iommu/amd: fix a race in fetch_pte() From: Qian Cai In-Reply-To: <20200429112014.GN21900@8bytes.org> Date: Wed, 29 Apr 2020 21:04:29 -0400 Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <4B6E0A22-C301-43C9-A8ED-AB473342463C@lca.pw> References: <20200418121022.GA6113@8bytes.org> <57CBF6B2-4745-4E36-9AA5-7E0876E3DA8F@lca.pw> <20200418183429.GH21900@8bytes.org> <7D03A3E2-647B-4FAD-886D-EE2764EC1EDB@lca.pw> <20200429112014.GN21900@8bytes.org> To: Joerg Roedel X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Apr 29, 2020, at 7:20 AM, Joerg Roedel wrote: >=20 > On Mon, Apr 20, 2020 at 09:26:12AM -0400, Qian Cai wrote: >> No dice. There could be some other races. For example, >=20 > Can you please test this branch: >=20 > = https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=3Dam= d-iommu-fixes >=20 > It has the previous fix in it and a couple more to make sure the > device-table is updated and flushed before increase_address_space() > updates domain->pt_root. It looks promising as it survives for a day=E2=80=99s stress testing. = I=E2=80=99ll keep it running for a few days to be sure.=