Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200426122237.j2ah64uoivp26ioj@debian.debian-2>
In-Reply-To: <20200426122237.j2ah64uoivp26ioj@debian.debian-2>
From:   Bo YU <tsu.yubo@gmail.com>
Date:   Thu, 30 Apr 2020 09:23:52 +0800
Message-ID: <CAKq8=3JFn8D1wjd==g0cFov935cyvd=DybCzvWG1PM8NrcMUXw@mail.gmail.com>
Subject: Re: [PATCH -next] block/genhd: align title and output
To:     axboe@kernel.dk
Cc:     linux-block@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Apr 26, 2020 at 8:22 PM Bo YU <tsu.yubo@gmail.com> wrote:
>
> Before the patch:
>
> major minor  #blocks  name
>
>  254        0   57671680 vda
>  254        1   57670656 vda1
>
> After the patch:
>
> major minor   #blocks    name
>
> 254   0       57671680   vda
> 254   1       57670656   vda1
>
> According to LDD3,major device maximun number is 12 bit,as it has 4 char
> placeholders.minor device maximum number is 20 bit(7 char palceholders)
> and keeping 10 char palceholders for blocks tag.If want to keep
> palceholder's numbers dynamiclly, There is more tricks to do that.  So i
> keep it simple.
>
> Signed-off-by: Bo YU <tsu.yubo@gmail.com>
> ---
>  block/genhd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/genhd.c b/block/genhd.c
> index 06b642b23a07..63a483cf76b9 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -1151,7 +1151,7 @@ static void *show_partition_start(struct seq_file *seqf, loff_t *pos)
>
>         p = disk_seqf_start(seqf, pos);
>         if (!IS_ERR_OR_NULL(p) && !*pos)
> -               seq_puts(seqf, "major minor  #blocks  name\n\n");
> +               seq_puts(seqf, "major minor   #blocks    name\n\n");
>         return p;
>  }
>
> @@ -1172,7 +1172,7 @@ static int show_partition(struct seq_file *seqf, void *v)
>         /* show the full disk and all non-0 size partitions of it */
>         disk_part_iter_init(&piter, sgp, DISK_PITER_INCL_PART0);
>         while ((part = disk_part_iter_next(&piter)))
> -               seq_printf(seqf, "%4d  %7d %10llu %s\n",
> +               seq_printf(seqf, "%-4d  %-7d %-10llu %s\n",
>                            MAJOR(part_devt(part)), MINOR(part_devt(part)),
>                            (unsigned long long)part_nr_sects_read(part) >> 1,
>                            disk_name(sgp, part->partno, buf));
> --
> 2.11.0
>
Sorry, Ping again