Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1270637ybz; Wed, 29 Apr 2020 18:33:40 -0700 (PDT) X-Google-Smtp-Source: APiQypK6VILzj1Kb0WcKSwS373fQJa/XuEX5IGRlmF51/pVq/QfWg/YTjTmCsKOoZNs1H2QEfud6 X-Received: by 2002:a05:6402:129a:: with SMTP id w26mr634509edv.254.1588210420538; Wed, 29 Apr 2020 18:33:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588210420; cv=none; d=google.com; s=arc-20160816; b=uXkJFzSAV1b2xGcyeRs47w4cGlGPYqedkBE9S9434sQj/0kLz/3sUH4oQsqC4X9/eB 0dy4LumllykPkiy3Qjy5WGXd4TW8mQ7b0JIUjJu6IcrPqU4I8Gq5Ys8CW7j9cZFP9pW0 cuSO5ALIS2J+MOd00UmG1zA/lVk4BDm+bJGoJrNTiUpM7LCyJmKDZyoN14zsQov9+NQU RrE/UW1HxKszKbXRCwRH+4irHpDAcp5eQNSBbUg9mO/viSXqASPTwbhQvzlVpK4bg4Gq GBSylABjBemqX1OZvqGscNMs6YYbBzjMrmSmoTUFNKHt2uT8wRjx00a26I6DBPWRxgEE 59wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition:mime-version :message-id:subject:to:from:date:dkim-signature:dkim-signature; bh=SYK7O3pWETptKlBHEnGL7d2b/hjrdjwGHndWnjpBIYc=; b=vaDYjgJN0xuDeib4/DkF/pUV/mHT1/Yt4hL4eJGiaDiCw1vHRhOOj6xAOQwPVeK/9R EDAfb2uVDUqfKKEZMu8Ui4mtrZZz9clfG/eNFG1SEov6NYdohx/zeSWHKV+BntKxPCXT ce8MeM44jAUNQqn5QTRNutO6shMI1dyGQXwz0hwp2fY5qAkalBUcGjW+S9630Np7Xmgc pngo7JJmtkF/VD+u2ZXGxf6jLokpL55qSYFiTCaAMkm1P26CYKVX0pN7y8ZH0v6kRte0 4Q3+u+hkzNj98YC3TRywyrFfJyA8twLEWY8zi8hbbKJ4JhQo6vHOqfB0dfZA/9NLVHjZ 6HgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rylan.coffee header.s=fm3 header.b=I9Rl+wyc; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b="nj/QXmBs"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x15si4916285edl.247.2020.04.29.18.33.16; Wed, 29 Apr 2020 18:33:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@rylan.coffee header.s=fm3 header.b=I9Rl+wyc; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b="nj/QXmBs"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726396AbgD3Bb5 (ORCPT + 99 others); Wed, 29 Apr 2020 21:31:57 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:51611 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbgD3Bb5 (ORCPT ); Wed, 29 Apr 2020 21:31:57 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DDF925C00A0; Wed, 29 Apr 2020 21:31:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 29 Apr 2020 21:31:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rylan.coffee; h= date:from:to:subject:message-id:mime-version:content-type; s= fm3; bh=SYK7O3pWETptKlBHEnGL7d2b/hjrdjwGHndWnjpBIYc=; b=I9Rl+wyc wAmq++yMiOioQj+oWaq9nyXI0XsLaqEES0VZqiZwG3prd4qZiNH07Q145rQ02dNq hiLZJ6vBIMkLZ2ndPBKwbqopvZdd6zvQY6vIbd5CGzWXB8MQPZXo3IJGiz2sxYEH jEWLbfFBRRoXGB3avlx202U5BnmawUUsOJzYvFaXNo9CnkQs1LeZA+ul2U79Gx+C YR/tYQJUGn89eRpeqo9C9aZ5QzVUl8RZbUM6wKXIli0Nk8dnqRQrQMqNvv4ubNt6 iASUhkOAh2Fc3GpsjNZ150ToHv9MC05eTZ13wdMxMXg/Iu93TTSsCBuxANMkhbUM ua3TxhhdnZ/dbQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=SYK7O3pWETptKlBHEnGL7d2b/hjrd jwGHndWnjpBIYc=; b=nj/QXmBskjFwJjZz1SEW1HTzdX8C72xA7b4qZZetuwHhN PhYYmRuYS1q3NXxGVLmOQPNBVgH9Nwqd0fzzHSZE5j2S37tLeO5EInEUUr/PMT4Q /VwbstVRlh3+Te5/QOaSsRpOzg3jxqiclLh5JMtyPtbXm1/MhOSI345DWRT6NiY+ Re6AGEKQvpx3TxC1FNlmHfv0KC2ps7kTtnDCJMH4oNayw2OEyCshrwzW45YuDnCt FcpKcLPcyN3llXYe4dHj7CAI3/8ym5xPdnFRKa8RLzo8vxmEpVtrfNCGURjxSj+L knem6Dwzvlf9Jwiu0XWft13qK+4rNWSxN+ep0XHPQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieeggdegiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkgggtugesthdtredttddtjeenucfhrhhomheptfihlhgrnhcuffhm vghllhhouceomhgrihhlsehrhihlrghnrdgtohhffhgvvgeqnecuggftrfgrthhtvghrnh epledukefggeevtdffjeduieefiedtuddufeeuvdehkeeuieelleeigfdvledufeelnecu kfhppedutdekrdegledrudehkedrkeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepmhgrihhlsehrhihlrghnrdgtohhffhgvvg X-ME-Proxy: Received: from athena (pool-108-49-158-84.bstnma.fios.verizon.net [108.49.158.84]) by mail.messagingengine.com (Postfix) with ESMTPA id 59DB73065EBD; Wed, 29 Apr 2020 21:31:55 -0400 (EDT) Date: Wed, 29 Apr 2020 21:31:54 -0400 From: Rylan Dmello To: Manish Chopra , GR-Linux-NIC-Dev@marvell.com, Greg Kroah-Hartman , netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Joe Perches Subject: [PATCH v2 0/7] staging: qlge: Checkpatch.pl indentation fixes in qlge_main.c Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patchset fixes some indentation- and style-related issues in qlge_main.c reported by checkpatch.pl, such as: WARNING: Avoid multiple line dereference WARNING: line over 80 characters WARNING: suspect code indent for conditional statements v2: - Addressed feedback from Joe Perches by unindenting ql_set_mac_addr_reg and by replacing goto statements with break statements in the function. Rylan Dmello (7): staging: qlge: Fix indentation in ql_set_mac_addr_reg staging: qlge: Remove gotos from ql_set_mac_addr_reg staging: qlge: Fix indentation in ql_get_mac_addr_reg staging: qlge: Remove goto statements from ql_get_mac_addr_reg staging: qlge: Remove multi-line dereference from ql_request_irq staging: qlge: Fix suspect code indent warning in ql_init_device staging: qlge: Fix function argument alignment warning in ql_init_device drivers/staging/qlge/qlge_main.c | 258 ++++++++++++++----------------- 1 file changed, 120 insertions(+), 138 deletions(-) -- 2.26.2