Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1273743ybz; Wed, 29 Apr 2020 18:37:44 -0700 (PDT) X-Google-Smtp-Source: APiQypKSAB4TeuGcE0zmqhxNVkzNPrTgvScMZI26VHtP9Jbob1H18Ot5DWzfBzn6E5IJ1MGtWGwv X-Received: by 2002:a17:906:f1d7:: with SMTP id gx23mr545311ejb.176.1588210664568; Wed, 29 Apr 2020 18:37:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588210664; cv=none; d=google.com; s=arc-20160816; b=pylXvrPnBHBWzen1200OcZ7ceFFL5Lx1LbYd2ps3ABkScVbaFz5TDlN8VgYmuBLPri FnW37/h2FAltMzW0iSgd3SkIccDO4qpPkQLHdqhUYsNmHwIqidNXWPouQVh1g1p76rNT j9JECSlwtw7ReZ0eu8OJroGaibBMnQxsS6c6C1yz2zgQS8qGvdA480380SDiUQfZN4Qh IXtdWh9kiwcjJ91AbnM6pxqqf1BZn+U3FS6uwvtBVQCGAjOjUuEa1+eATYNrgiPp85TJ jB+8VAyuk9PKc/Up5t/wTyDpoe/QFbQukj9unFThDWL81MHMwHVgPOxvol/8vk1kNY2t a4Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:to:from:date :dkim-signature:dkim-signature; bh=866EUhhl02ATxe+Ni9RioUHWCNy6rpkgxyOZFwaTNlE=; b=Ssh99GaWoGkPZDJ4eN4q33b/cPrAa/NKprdFKw0ZpvJwD/2MkcRucCdAKWaD5Eg0Un TGT9BXcUWwbFNaNjADN45hJSzQLb+hdIQFjIYAk2CLxw1KgZLn6s1Mv6/KUZsT+Bs1gs UglaeVzLzhkxxiWYPHnbbDHc9BNv6SdUOZPI6Rx+wTlwc96elMS9QHx6QDFpgqyBSyoZ 0GaQEPr2CEQLkL3RZeXS9gipCDUwrTUCmPBgKmUInCyI/8tBn76r2FdyltiDsTJEusTW bLFyqRFdFXRmmrMVPxklYvby9/3h/9Wkx4mvZE+502XC/tj8yb4Hj7F8hbNjYr74f/W+ kaDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rylan.coffee header.s=fm3 header.b=QFuuG32p; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=yXNLZJWC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m13si4917485ejc.7.2020.04.29.18.37.21; Wed, 29 Apr 2020 18:37:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@rylan.coffee header.s=fm3 header.b=QFuuG32p; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=yXNLZJWC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726774AbgD3Bdd (ORCPT + 99 others); Wed, 29 Apr 2020 21:33:33 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:44109 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726309AbgD3Bdd (ORCPT ); Wed, 29 Apr 2020 21:33:33 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AC7D45C0076; Wed, 29 Apr 2020 21:33:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 29 Apr 2020 21:33:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rylan.coffee; h= date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=866EUhhl02ATxe+Ni9RioUHWCNy 6rpkgxyOZFwaTNlE=; b=QFuuG32pi1HbQfBaqv1y7Zu3pVeTy2ymCaJZfw5utYe aOJCEl8Ql4Fbe95BN+nU6u3fVcrkZ5RI7mO6Ii0cc0gzN2E3ckO6VJhux6zYNJq3 P8oK8eCcN8qvZ4gzAx4wb40eEuW7rczH8clZwzEgZMAtTzbDedPnmTYiNYwrgta/ oSUEdtW3rnqWmzTolc6uw3vl6Zhxzj0FFoTUJG5onnyZ2UB570iG5JC1Po8uIgYw N8hUYedpupGVzhK5oN4InajRoKY55oCqK3lPAxr26VJoqguLJMN12OD8s7i0HnNJ FiXPocf52brArdwR9dmr0/AydEZuCwHRLsI/8tW6n9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=866EUh hl02ATxe+Ni9RioUHWCNy6rpkgxyOZFwaTNlE=; b=yXNLZJWClVX9FUflynGRK/ VdVrDMijK+s1HCfzLMS/S+X9mpyfAc1ydxetdssEqSmCAUc4hlIP2SX7zEHxLK3N 0VUOrTWSN6VsG4trnSLgg5P4RxaCstRQdZBREeYeuIhr2j8eGj/ccFju3XFqe5ua Z9EfXciXOEtxl8w0qRVWTJMFqjmdGqy6Z82s4qY2cmHRuyTCtyyHQQFr7HUqBq03 Kh4IrcipIyHK5js48i/U/QxlB16A3wW0kCVwmhQC2b2Af60Wrxu1i1ZN95SxRsjI LP64sCIOtJrJg+a4uF4zXeStb9YatRSXiJF4MC/NeS2fjLVSjwI0M47ABUvs9XYw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieeggdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtjeenucfhrhhomheptfihlhgrnhcu ffhmvghllhhouceomhgrihhlsehrhihlrghnrdgtohhffhgvvgeqnecuggftrfgrthhtvg hrnhepjeffvefffeevgfdtteegudffieduveeuhfettddvueehveethfffgeetfeeghfeu necukfhppedutdekrdegledrudehkedrkeegnecuvehluhhsthgvrhfuihiivgepudenuc frrghrrghmpehmrghilhhfrhhomhepmhgrihhlsehrhihlrghnrdgtohhffhgvvg X-ME-Proxy: Received: from athena (pool-108-49-158-84.bstnma.fios.verizon.net [108.49.158.84]) by mail.messagingengine.com (Postfix) with ESMTPA id 6238D3280066; Wed, 29 Apr 2020 21:33:30 -0400 (EDT) Date: Wed, 29 Apr 2020 21:33:29 -0400 From: Rylan Dmello To: Manish Chopra , GR-Linux-NIC-Dev@marvell.com, Greg Kroah-Hartman , netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Joe Perches Subject: [PATCH v2 3/7] staging: qlge: Fix indentation in ql_get_mac_addr_reg Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This has similar indentation style issues as ql_set_mac_addr_reg, so I thought I'd re-indent this too. Fix several checkpatch.pl warnings: WARNING: line over 80 characters Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 76 ++++++++++++++++---------------- 1 file changed, 37 insertions(+), 39 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index f2b4a54fc4c0..844c2c6df38d 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -262,52 +262,50 @@ int ql_get_mac_addr_reg(struct ql_adapter *qdev, u32 type, u16 index, switch (type) { case MAC_ADDR_TYPE_MULTI_MAC: - case MAC_ADDR_TYPE_CAM_MAC: - { - status = - ql_wait_reg_rdy(qdev, - MAC_ADDR_IDX, MAC_ADDR_MW, 0); - if (status) - goto exit; - ql_write32(qdev, MAC_ADDR_IDX, (offset++) | /* offset */ + case MAC_ADDR_TYPE_CAM_MAC: { + status = ql_wait_reg_rdy(qdev, MAC_ADDR_IDX, MAC_ADDR_MW, 0); + if (status) + goto exit; + ql_write32(qdev, MAC_ADDR_IDX, + (offset++) | /* offset */ (index << MAC_ADDR_IDX_SHIFT) | /* index */ - MAC_ADDR_ADR | MAC_ADDR_RS | type); /* type */ - status = - ql_wait_reg_rdy(qdev, MAC_ADDR_IDX, MAC_ADDR_MR, 0); - if (status) - goto exit; - *value++ = ql_read32(qdev, MAC_ADDR_DATA); - status = - ql_wait_reg_rdy(qdev, MAC_ADDR_IDX, MAC_ADDR_MW, 0); + MAC_ADDR_ADR | MAC_ADDR_RS | + type); /* type */ + status = ql_wait_reg_rdy(qdev, MAC_ADDR_IDX, MAC_ADDR_MR, 0); + if (status) + goto exit; + *value++ = ql_read32(qdev, MAC_ADDR_DATA); + status = ql_wait_reg_rdy(qdev, MAC_ADDR_IDX, MAC_ADDR_MW, 0); + if (status) + goto exit; + ql_write32(qdev, MAC_ADDR_IDX, + (offset++) | /* offset */ + (index << MAC_ADDR_IDX_SHIFT) | /* index */ + MAC_ADDR_ADR | MAC_ADDR_RS | + type); /* type */ + status = ql_wait_reg_rdy(qdev, MAC_ADDR_IDX, MAC_ADDR_MR, 0); + if (status) + goto exit; + *value++ = ql_read32(qdev, MAC_ADDR_DATA); + if (type == MAC_ADDR_TYPE_CAM_MAC) { + status = ql_wait_reg_rdy(qdev, MAC_ADDR_IDX, + MAC_ADDR_MW, 0); if (status) goto exit; - ql_write32(qdev, MAC_ADDR_IDX, (offset++) | /* offset */ - (index << MAC_ADDR_IDX_SHIFT) | /* index */ - MAC_ADDR_ADR | MAC_ADDR_RS | type); /* type */ - status = - ql_wait_reg_rdy(qdev, MAC_ADDR_IDX, MAC_ADDR_MR, 0); + ql_write32(qdev, MAC_ADDR_IDX, + (offset++) | /* offset */ + (index + << MAC_ADDR_IDX_SHIFT) | /* index */ + MAC_ADDR_ADR | + MAC_ADDR_RS | type); /* type */ + status = ql_wait_reg_rdy(qdev, MAC_ADDR_IDX, + MAC_ADDR_MR, 0); if (status) goto exit; *value++ = ql_read32(qdev, MAC_ADDR_DATA); - if (type == MAC_ADDR_TYPE_CAM_MAC) { - status = - ql_wait_reg_rdy(qdev, - MAC_ADDR_IDX, MAC_ADDR_MW, - 0); - if (status) - goto exit; - ql_write32(qdev, MAC_ADDR_IDX, (offset++) | /* offset */ - (index << MAC_ADDR_IDX_SHIFT) | /* index */ - MAC_ADDR_ADR | MAC_ADDR_RS | type); /* type */ - status = - ql_wait_reg_rdy(qdev, MAC_ADDR_IDX, - MAC_ADDR_MR, 0); - if (status) - goto exit; - *value++ = ql_read32(qdev, MAC_ADDR_DATA); - } - break; } + break; + } case MAC_ADDR_TYPE_VLAN: case MAC_ADDR_TYPE_MULTI_FLTR: default: -- 2.26.2