Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1297654ybz; Wed, 29 Apr 2020 19:10:52 -0700 (PDT) X-Google-Smtp-Source: APiQypI234UkctLC/I7eoRer9YSYeYTxRniAaiByj/TDJvYx3mBAkKf8n96iym8knfp9bcXIZiR1 X-Received: by 2002:aa7:d783:: with SMTP id s3mr784856edq.64.1588212652578; Wed, 29 Apr 2020 19:10:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588212652; cv=none; d=google.com; s=arc-20160816; b=pSvN5GoGr8BMfLAX+nImn7PNKcH5fmw+wG5yL/ekbx3TcbhMaHVRRc3Xv7hSHMJGjk KMPGrfGCKs1uqMHBf/B5NS5GlQ7MZujB0xUjD4oJkwrQspnNwsx1aRswzTHWSxvg82U+ 2RmxHV8Kv8jpJ+bTd5LCUSQfYMOyGa+ah0dH/AfxYF71dFT58A33XjlDo9KWmh2NcjxP Y7pYBBChg2iSGJ5IKAW/gO6DhEwGWMvbTGloOxOlYhByL1E07axIQtBf7L0NQZeUPhih ctj5xd3dtBC/1LthNHGj6l3ejOlj6ANgo2sJZReexDeEFRtn/2/nSQJDcP645qlEJ78M hvbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=ZlVXfVLGNb+NmjnYb/rWzFG8Achiid3jCCJ8y0VumIM=; b=AAC30DKPdYcDvNZ05WfHVQia3DXJWLBa37TR+Nn0H2IM82a5diFIyqA7JsVVtx/7+A yxDxESUVrGOgSVRk5TonHLdSQBhaWIZewkCQzIzQZko8Nhu+EzBkEAdgoymG3R2nmbNf Rezj9LtxmXQOTEqEFEBWG2Rn1XU1ezMrmxXIPljhjo7wH4xGyfM9cbuwu7WzE3CJXd5l ipB8DRqmwfHcm8BPDXcP2pNbkWJY621GyfOxllG9JZy8JuSV9R8G4cWW1d1wNV5m/SF3 grCqgciLXyho5at5CdUz+QcsXxXMgzbYCbYiQgUoxc7eBwictN5MqYCK6aS/LkS3IqKy zgkQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dj13si4609362edb.342.2020.04.29.19.10.29; Wed, 29 Apr 2020 19:10:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726554AbgD3CJD (ORCPT + 99 others); Wed, 29 Apr 2020 22:09:03 -0400 Received: from mga07.intel.com ([134.134.136.100]:43401 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726282AbgD3CJC (ORCPT ); Wed, 29 Apr 2020 22:09:02 -0400 IronPort-SDR: JJQalPwEsayv6UwnqOebbrTxeM+fgFr3y+HoOkUQpvPkC8jj6Vv+sEJqgd374U0/0nvhYjEKYt UGrjBZGhyRMw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 19:09:01 -0700 IronPort-SDR: zBgAtl8/TZEyl3/1bRQfDWBdxpFSgnk1pqExldm0ubv31vBu/ATCmg7epE00CadkKK/EBaWmYZ mLVvSnkxADDg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,333,1583222400"; d="scan'208";a="405242122" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by orsmga004.jf.intel.com with ESMTP; 29 Apr 2020 19:09:01 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id C52C8301AAA; Wed, 29 Apr 2020 19:09:01 -0700 (PDT) Date: Wed, 29 Apr 2020 19:09:01 -0700 From: Andi Kleen To: Stephane Eranian Cc: LKML , Peter Zijlstra , mingo@elte.hu, Arnaldo Carvalho de Melo , Jiri Olsa , Ian Rogers , "Liang, Kan" Subject: Re: [PATCH] perf/script: remove extraneous newline in perf_sample__fprintf_regs() Message-ID: <20200430020901.GC874567@tassilo.jf.intel.com> References: <20200418231908.152212-1-eranian@google.com> <20200428024744.GA703870@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I was under the impression that perf script was generating one line > per sample. Otherwise, seems hard to parse. That's only true for simple cases. A lot of the extended output options have long generated multiple lines. And of course call stacks always did. > Could you give me the cmdline options of perf script that justify the newline. e.g. perf script -F iregs,uregs -Andi