Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1304222ybz; Wed, 29 Apr 2020 19:19:59 -0700 (PDT) X-Google-Smtp-Source: APiQypI+IwwDJrPnPN6RY4k84DorqsZtPwAtO71VO8v6sW17WC/6sXuVCBljcBTbwcNO0tw/LHYf X-Received: by 2002:a17:906:f1c3:: with SMTP id gx3mr647693ejb.25.1588213199447; Wed, 29 Apr 2020 19:19:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588213199; cv=none; d=google.com; s=arc-20160816; b=r+y8T3mMUR96dADQ0phD9YB/e/f65MApdAfBwdM8NKa2dpRBSOXFcBMWtOSrLZXYKg qKHmHXuo547PAdl8X6SSZD/zIXAnOdAIkkRcep81vPKj9T4FZFBqgj3KzYfo1BGHpSxt AqltBMb7794pa5zw1Ot2Kpai5j7zX+ZsEP+b7K/4FRzZASrbxATL/r/rtg1SbTd2X35u b/2BVT4bDBxaG4SaUjJ4skiBvKAyO8YNdyXTH6dbtZW/mtKxryUaJ/FPlpioHkJbYa4e 5uBIRRJXtBhQfPfLZcd7xUAHRHCct8O6vkXmV9tPht1cuozzSE7fKcOtfdKuU/IhPEm2 Z7yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1EpdnCTaGeK6kaN+YXuEy0NQfId+N/eZu0x/n1++L24=; b=tuE+z/22xeaBoMOQTR/kDzqHr3zdiRzyXllM1yYhYkenwUSu6kTelLjqlYxslt8Tml rhLA+VVEiWTPkeIOyWO+DXrJMHoLYI/jHP7GPmqDUsx7yeZVH8Mw73iHwQ6sIKuQGqfT 1KHei5p+ocnRmjZY9nUN3hYH993q0YyWWMY1oiMp9WyMDHd5te1NL5OxkxazCYCiD1p9 Mc3IUlUWRoPX6HSAkbmyapaZToNBtTfE0XGmb9bbVE0Lg9zkUIPkv5LKpFyGGDkpgjNk sgn6Du7Y17fdszZS6z6UEtq3lv+Kr2wUzsY6uyCJSar7YrrTI0t9Fw9OCymxg5bid3BZ dfew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=TNXZp5bl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ec15si4956161ejb.286.2020.04.29.19.19.36; Wed, 29 Apr 2020 19:19:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=TNXZp5bl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726554AbgD3CSQ (ORCPT + 99 others); Wed, 29 Apr 2020 22:18:16 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:43730 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726180AbgD3CSQ (ORCPT ); Wed, 29 Apr 2020 22:18:16 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03U2HnNR095384; Thu, 30 Apr 2020 02:18:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2020-01-29; bh=1EpdnCTaGeK6kaN+YXuEy0NQfId+N/eZu0x/n1++L24=; b=TNXZp5blPFYqKb9u05Adt4NZDOoDfLcy+c2AYfdwzoTuZU2EAbYoywE22AFXEPrW8zVz LIx79oeY+Yjq+SLv2QIaxRCBeQtL7hjC5WreRBeB7pyOinuVVqZHEEVdoSPu0wTxzOV/ /h7pBQEsG+BH3bG9YTmguNJa10BMOWyaEI1gQVaYObnMPQLQi1bWAZG9nkFcsjpMwLDT 3I+96bZXMS1F/9JScURLkzQnQi46mnKZ/38znzJINYYD4SNjMm0ja9VHNpdWVrI3Zgm6 by5EX9mafkWxFeb+We75pKKThUaKoYyJGDABIZh0bfRrLu+PUiYWPqH2MQga6gFoFpJs +g== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 30p01nyf2d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 Apr 2020 02:18:09 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03U2I8vL114392; Thu, 30 Apr 2020 02:18:09 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 30mxrwcya0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 Apr 2020 02:18:08 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 03U2I5be008456; Thu, 30 Apr 2020 02:18:05 GMT Received: from ca-mkp.ca.oracle.com (/10.156.108.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 Apr 2020 19:18:05 -0700 From: "Martin K. Petersen" To: Arun Easi , Nilesh Javali , linux-scsi@vger.kernel.org, "James E . J . Bottomley" , GR-QLogic-Storage-Upstream@marvell.com, Colin King , Himanshu Madhani Cc: "Martin K . Petersen" , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH][next] scsi: qla2xxx: make 1 bit bit-fields unsigned int Date: Wed, 29 Apr 2020 22:18:01 -0400 Message-Id: <158821297686.28621.17012076745454768383.b4-ty@oracle.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200428102013.1040598-1-colin.king@canonical.com> References: <20200428102013.1040598-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9606 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 suspectscore=0 mlxlogscore=858 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004300015 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9606 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 clxscore=1015 phishscore=0 mlxlogscore=913 adultscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004300014 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Apr 2020 11:20:13 +0100, Colin King wrote: > The bitfields mpi_fw_dump_reading and mpi_fw_dumped are currently signed > which is not recommended as the representation is an implementation defined > behaviour. Fix this by making the bit-fields unsigned ints. Applied to 5.8/scsi-queue, thanks! [1/1] scsi: qla2xxx: make 1-bit bit-fields unsigned int https://git.kernel.org/mkp/scsi/c/78b874b7cbf0 -- Martin K. Petersen Oracle Linux Engineering