Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1588216490-60282-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1588216490-60282-1-git-send-email-zou_wei@huawei.com>
From:   Huacai Chen <chenhuacai@gmail.com>
Date:   Thu, 30 Apr 2020 12:06:19 +0800
Message-ID: <CAAhV-H4Zh60bLLVkhZ7fJTRkBvqxiCuogHyQv-S9rC_e0+HZNw@mail.gmail.com>
Subject: Re: [PATCH -next] KVM: MIPS/VZ: Remove unneeded semicolon
To:     Zou Wei <zou_wei@huawei.com>
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        "open list:MIPS" <linux-mips@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Reviewed-by: Huacai Chen <chenhc@lemote.com>

On Thu, Apr 30, 2020 at 11:08 AM Zou Wei <zou_wei@huawei.com> wrote:
>
> Fixes coccicheck warnings:
>
> arch/mips/kvm/vz.c:1186:4-5: Unneeded semicolon
> arch/mips/kvm/vz.c:1195:3-4: Unneeded semicolon
> arch/mips/kvm/vz.c:1949:3-4: Unneeded semicolon
> arch/mips/kvm/vz.c:1121:2-3: Unneeded semicolon
> arch/mips/kvm/vz.c:2188:3-4: Unneeded semicolon
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  arch/mips/kvm/vz.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/mips/kvm/vz.c b/arch/mips/kvm/vz.c
> index dde2088..389dd0f 100644
> --- a/arch/mips/kvm/vz.c
> +++ b/arch/mips/kvm/vz.c
> @@ -1118,7 +1118,7 @@ static enum emulation_result kvm_vz_gpsi_cache(union mips_instruction inst,
>                 break;
>         default:
>                 break;
> -       };
> +       }
>
>         kvm_err("@ %#lx/%#lx CACHE (cache: %#x, op: %#x, base[%d]: %#lx, offset: %#x\n",
>                 curr_pc, vcpu->arch.gprs[31], cache, op, base, arch->gprs[base],
> @@ -1183,7 +1183,7 @@ static enum emulation_result kvm_trap_vz_handle_gpsi(u32 cause, u32 *opc,
>                                 trace_kvm_hwr(vcpu, KVM_TRACE_RDHWR,
>                                               KVM_TRACE_HWR(rd, sel), 0);
>                                 goto unknown;
> -                       };
> +                       }
>
>                         trace_kvm_hwr(vcpu, KVM_TRACE_RDHWR,
>                                       KVM_TRACE_HWR(rd, sel), arch->gprs[rt]);
> @@ -1192,7 +1192,7 @@ static enum emulation_result kvm_trap_vz_handle_gpsi(u32 cause, u32 *opc,
>                         break;
>                 default:
>                         goto unknown;
> -               };
> +               }
>                 break;
>  unknown:
>
> @@ -1946,7 +1946,7 @@ static int kvm_vz_get_one_reg(struct kvm_vcpu *vcpu,
>                 default:
>                         *v = (long)kvm_read_c0_guest_prid(cop0);
>                         break;
> -               };
> +               }
>                 break;
>         case KVM_REG_MIPS_CP0_EBASE:
>                 *v = kvm_vz_read_gc0_ebase();
> @@ -2185,7 +2185,7 @@ static int kvm_vz_set_one_reg(struct kvm_vcpu *vcpu,
>                 default:
>                         kvm_write_c0_guest_prid(cop0, v);
>                         break;
> -               };
> +               }
>                 break;
>         case KVM_REG_MIPS_CP0_EBASE:
>                 kvm_vz_write_gc0_ebase(v);
> --
> 2.6.2
>