Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 30 Apr 2020 07:03:44 +0200
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Michal Kubecek <mkubecek@suse.cz>,
        David Jander <david@protonic.nl>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>, mkl@pengutronix.de,
        Marek Vasut <marex@denx.de>,
        Christian Herber <christian.herber@nxp.com>
Subject: Re: [PATCH net-next v3 2/2] net: phy: tja11xx: add support for
 master-slave configuration
Message-ID: <20200430050344.u7bsakcrrw2cakex@pengutronix.de>
References: <20200428075308.2938-1-o.rempel@pengutronix.de>
 <20200428075308.2938-3-o.rempel@pengutronix.de>
 <20200429182053.GM30459@lunn.ch>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="aevfvnzd6ykgpc2t"
Content-Disposition: inline
In-Reply-To: <20200429182053.GM30459@lunn.ch>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--aevfvnzd6ykgpc2t
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 29, 2020 at 08:20:53PM +0200, Andrew Lunn wrote:
> > +static int tja11xx_config_aneg(struct phy_device *phydev)
> > +{
> > +	u16 ctl =3D 0;
> > +	int ret;
> > +
> > +	switch (phydev->master_slave_set) {
> > +	case PORT_MODE_CFG_MASTER_FORCE:
> > +	case PORT_MODE_CFG_MASTER_PREFERRED:
> > +		ctl |=3D MII_CFG1_MASTER_SLAVE;
> > +		break;
> > +	case PORT_MODE_CFG_SLAVE_FORCE:
> > +	case PORT_MODE_CFG_SLAVE_PREFERRED:
> > +		break;
> > +	case PORT_MODE_CFG_UNKNOWN:
> > +		return 0;
> > +	default:
> > +		phydev_warn(phydev, "Unsupported Master/Slave mode\n");
> > +		return -ENOTSUPP;
> > +	}
>=20
> Does the hardware actually support PORT_MODE_CFG_SLAVE_PREFERRED and
> PORT_MODE_CFG_MASTER_PREFERRED? I thought that required autoneg, which
> this PHY does not support? So i would of expected these two values to
> return ENOTSUPP?

I do not have strong opinion here. Will change it.

Regards,
Oleksij
--=20
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

--aevfvnzd6ykgpc2t
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEERBNZvwSgvmcMY/T74omh9DUaUbMFAl6qXDAACgkQ4omh9DUa
UbNSIxAAnuqCCyRXMKpPIyGfOO+VHRzckemdFoGwEclePdskhMp3rMPTED/iOcDa
r75OTE65mCoKQ+epY3Dx5ZitqdinLbSctLlSePg/74lNPsLQBUrr8tH2CnTeQ9z0
qKfakIIgK5B+MdZLxIzV913Vfp7e29f4vjON/LeqkenNLxoxprVCUsz51cQYta+t
d2JnwJVRhlMG+wveRVlfFksItFh0W3I+MbN12ICLEKCzqzRYZqjq57RWWu2PLEDV
sprC2I0p3C9ZZOCzNVqz1LY0nJZnZMFJzbxlCC9BcWT+w3KUk3qoEAxg2jyu2kD4
DW+kmRcKUwgv+4RYWmmn4jiF+Dmfikf7OmdTvQF5w5KzC82eJwTzaP5qb3X3QFC4
QeO0FPc3Uf2o0FvEsm1PYXtofamAaUDq2JyvybNjHn6Rto4HfQZWQXkdKJfE33jJ
h54c9UshwhZ2aOmo0cN2JBJlbQrXV7HtYxVusu9k8nik4w1cNDEetSh74EyeGV5i
yUpkHRs1lD/TI8r+ZR5JCFMQwqA6BxGw53HYjZFdy4kWpLeIF+gcGhlvF6r1hgdK
2omXLdYODGYSUCpe9C9tclb6lhmxq1ue48HgFmM577Xi4jJTFLiYeAywQ3M3B7xp
f1f4WSTdkKKerYzsR+Ce8z/AhmysLBnjCxCb2/bp/Zppq68DCj0=
=U6If
-----END PGP SIGNATURE-----

--aevfvnzd6ykgpc2t--