Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 30 Apr 2020 08:42:51 +0200
From:   Greg KH <greg@kroah.com>
To:     Doug Anderson <dianders@chromium.org>
Cc:     Ohad Ben-Cohen <ohad@wizery.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-remoteproc@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Clement Leger <cleger@kalray.eu>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Evan Green <evgreen@chromium.org>
Subject: Re: [PATCH] remoteproc: Fix wrong rvring index computation
Message-ID: <20200430064251.GE2377651@kroah.com>
References: <20191004073736.8327-1-cleger@kalray.eu>
 <CAD=FV=WgUNySbRE9dZys28fFo3eZwf_2=cj68jaw1ftakJDzVQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAD=FV=WgUNySbRE9dZys28fFo3eZwf_2=cj68jaw1ftakJDzVQ@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 29, 2020 at 04:26:41PM -0700, Doug Anderson wrote:
> Hi,
> 
> On Fri,  4 Oct 2019 Clement Leger <cleger@kalray.eu> wrote:
> >
> > Index of rvring is computed using pointer arithmetic. However, since
> > rvring->rvdev->vring is the base of the vring array, computation
> > of rvring idx should be reversed. It previously lead to writing at negative
> > indices in the resource table.
> >
> > Signed-off-by: Clement Leger <cleger@kalray.eu>
> > ---
> >  drivers/remoteproc/remoteproc_core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Randomly stumbled upon this in a list of patches.  This patch landed
> in mainline as:
> 
> 00a0eec59ddb remoteproc: Fix wrong rvring index computation
> 
> Should it be queued up for stable?  I'm guessing:
> 
> Fixes: c0d631570ad5 ("remoteproc: set vring addresses in resource table")

Thanks, now queued up.

greg k-h