Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 30 Apr 2020 10:20:22 +0300
From:   Arseny Maslennikov <ar@cs.msu.ru>
To:     Jiri Slaby <jslaby@suse.cz>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        Rob Landley <rob@landley.net>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Pavel Machek <pavel@ucw.cz>, linux-api@vger.kernel.org,
        "Vladimir D. Seleznev" <vseleznv@altlinux.org>
Message-ID: <20200430072022.GI43805@cello>
References: <20200430064301.1099452-1-ar@cs.msu.ru>
 <20200430064301.1099452-6-ar@cs.msu.ru>
 <323be592-b614-907d-e9be-4748f159fb07@suse.cz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="aFi3jz1oiPowsTUB"
Content-Disposition: inline
In-Reply-To: <323be592-b614-907d-e9be-4748f159fb07@suse.cz>
OpenPGP: url=http://grep.cs.msu.ru/~ar/pgp-key.asc
Subject: Re: [PATCH v3 5/7] tty: Add NOKERNINFO lflag to termios
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--aFi3jz1oiPowsTUB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 30, 2020 at 08:55:43AM +0200, Jiri Slaby wrote:
> On 30. 04. 20, 8:42, Arseny Maslennikov wrote:
> > The termios lflag is off by default.
>=20
> This commit message is too poor. Describing the intended use would help.
>=20

I described its use in the last patch of the series, where it actually
gains some use.

I agree, however, that the limited explanation in this commit does not
look helpful at all when looking at e.g. git blame output.

I'll resend a v4 with this commit message improved.

--aFi3jz1oiPowsTUB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE56JD3UKTLEu/ddrm9dQjyAYL01AFAl6qfCkACgkQ9dQjyAYL
01BFHhAAml+XD+qV4guDdTSNwGuvJNRkulv3C56N+UT8iqccZPDr2kKn38Flkv/W
2nj2+kuDbtil6wdf9bqojHA1itVdiTaaeNPGfOFNr9jr0FgDaBjwHAQaMrsNWknD
xHx7XXj9zz4MlnKZx+eWNgSdiyGBPaTZFojZp0fN76HN5oD5/Kx7sEaY8UFs16dw
uz0p1+rNmwMK9VQ43hcAML1jW1qH/NHTgeOVmvUC0JEqXxvz844E2HjtpttRZvTy
8iccSRdOLS5f5yFRNucK4gIYXRP+lm1Co3iM3rqOKt02dZm+tooCsydyzFX6glDO
vcK0ZRoAa8sxQZBmtYXdGhpPsEzhg2ODjcOKfRjRC3fSnXGiU83b9gUg6e5Z7Ocs
1F9l5bDDjiAQNZBXO2rJPVPjvXNSY/PeVofXJyNWO7mA2+ajHfp4D05lBh03Z6o6
fhWOjAG2uCTWwNrUf2x8tObGvnUQyZMDStA0jx0JV/HjPQFLYOOlvnxGaP6v/C59
iYoqctMXY26sphySOon8S3lEubfbL1d/WVYuUK/CHyIajhUP0wHSC1el11ndCJXD
JMdrxjVFMsUB9J1psz/X7bXcgb5GD/GKkNsRjWwUEwFpB+3RhRcsC0GFYWidiSoC
djVdRtD0ukmyVCUAYKdgK7q/9LeXNsFOXXDYXeLxUcw40ghhQTo=
=6OEc
-----END PGP SIGNATURE-----

--aFi3jz1oiPowsTUB--