Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1572451ybz; Thu, 30 Apr 2020 01:35:11 -0700 (PDT) X-Google-Smtp-Source: APiQypI32N1dUjIhte8pZ/IkZ955IcNMfGIN6v3MeMXodUyBAtFZonNC1TGW2oz1LqNLtKfzzVND X-Received: by 2002:a17:906:7282:: with SMTP id b2mr1693053ejl.161.1588235710924; Thu, 30 Apr 2020 01:35:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588235710; cv=none; d=google.com; s=arc-20160816; b=W5JkJi/q64+YUfL5zk7vW5GYkvfYkpJd4NrKVs+QJve11gVkPwLco8qz7L0U2fgFRl A+TT9zbleqrTcvAf27dmsIaej6xSWdoUpm3DuAAcR3KY1Vt3x6wVsvrisviznJtKFCR/ t4+qp7lKRojjCYe7eXLwMrxadFpVQsfQbfSnnGnjIl/ESBXMY9y0vdE5/9kUbB+Meqsh qE59cQKY7BOHRxnrWTsRFwX9hIOyxOLlfr2+Rqg5MnmXd5axTUST3j0nI2i4g2wBss9e yRSjrxgLjSvx24OAE9B7iq49DVHN3U0qHZkc0jq8gvYgxdRhQkrMrpngJAbyBQb0Dwga N7KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=+AM9PuSEX9CkKY+wHvmB0UaYPgx6LA/l1dSgFvt/HiA=; b=k7QCVqXoUZUszUcW70Hbuhkg6y91lMgZOroQdEqBxaxFwLM5V+9zaDEGV8u0kh/FdR Ocmqd3v7Ey2a9l/Nm+hmKUeuQFdhx8QSU7SPt/TOJQE5YxR+Zd3BjGEvupVRTa/74djH dgRhMhltP7xY3UhUoxLCO/m32jcNeuktLM8daa9MIdfbhk72g0yCPZtzLJ9WsPaMGf28 ANUel+xzI/4k6jTAwVGdTNamoA32SV6ergekNUnUrebvnHvV/HNJbGEQMAq6+Q6XF12p Uj9KVYPCtx8IRGlQ053hj6Ku7mHYclT6tYdHGhK2I2Hnh18xmHBbE8V3Kpx5gACLrHoF qhFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u21si5486005ejz.518.2020.04.30.01.34.46; Thu, 30 Apr 2020 01:35:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726783AbgD3IdV (ORCPT + 99 others); Thu, 30 Apr 2020 04:33:21 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38533 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726412AbgD3IdU (ORCPT ); Thu, 30 Apr 2020 04:33:20 -0400 Received: from 61-220-137-37.hinet-ip.hinet.net ([61.220.137.37] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jU4d0-0002x7-4F; Thu, 30 Apr 2020 08:33:06 +0000 From: Kai-Heng Feng To: tiwai@suse.com Cc: Kai-Heng Feng , Jaroslav Kysela , Kailang Yang , Hui Wang , Jian-Hong Pan , Tomas Espeleta , Thomas Hebb , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , alsa-devel@alsa-project.org (moderated list:SOUND), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/3] ALSA: hda/realtek - Enable micmute LED on and HP system Date: Thu, 30 Apr 2020 16:32:52 +0800 Message-Id: <20200430083255.5093-2-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200430083255.5093-1-kai.heng.feng@canonical.com> References: <20200430083255.5093-1-kai.heng.feng@canonical.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Though the system uses DMIC, headset mic still uses the HDA, let's use GPIO 0x1 to control the micmute LED. The micmute LED GPIO has a different polarity to the mute LED GPIO, we can use the newly added micmute_led_polarity to indicate that. Signed-off-by: Kai-Heng Feng --- sound/pci/hda/patch_realtek.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 3150a61befc5..6f164ccddde3 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4134,7 +4134,11 @@ static void alc269_fixup_hp_gpio_led(struct hda_codec *codec, static void alc285_fixup_hp_gpio_led(struct hda_codec *codec, const struct hda_fixup *fix, int action) { - alc_fixup_hp_gpio_led(codec, action, 0x04, 0x00); + struct alc_spec *spec = codec->spec; + + spec->micmute_led_polarity = 1; + + alc_fixup_hp_gpio_led(codec, action, 0x04, 0x01); } static void alc286_fixup_hp_gpio_led(struct hda_codec *codec, -- 2.17.1