Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1642325ybz; Thu, 30 Apr 2020 03:00:09 -0700 (PDT) X-Google-Smtp-Source: APiQypL+10P9YkYJkjiMSnVj4P6j4x9w96AyVVF0YcqejZjYzbyMm7wADurO+xAd/7LT2u3BN57u X-Received: by 2002:a17:906:7f0c:: with SMTP id d12mr1863408ejr.40.1588240808889; Thu, 30 Apr 2020 03:00:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588240808; cv=none; d=google.com; s=arc-20160816; b=JzMnx9Wi60CNPMNiawzmiOSpW63shR0mXVnjYdK/nb0zR9NMT5+MfLABpNVc667LMd 2VOn+EWH9JikLnfFCEYYhIJ85xMsZVIPAal1qW5GnwBIRh3yetZvMfH8t8OE8lPVzFSR 8pkwaChOw58D1idw8cClOFZKaUti/n1szNbxuT3Ra7AX7UrW1O9lNr6pufdIaFAZMbr0 ov3LH5RmYdvvrggjUXGHRx2TM/1LAawD33CTSnbEwIytTaJihPd9j+cMw39K95/znj68 jF0+Yma/lL4HMu2Hs6fNtDrG+/e3KOMDl3z3ctIJODzYnYx47ndp4zIkYFDudVXd0wm3 MgRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=8IRqw0UgITQr6qLen/zMGgXI3kllNIGXWU/YVtVxi7o=; b=RKuy34HsZpzP1QcoHSAjoUKyYDhq27FmfeAv54nCB8dIjsNAssZ2VAckdfXwW3rNhS f6T8+dtHWC36Xb4FBEZ0MDr3SpDDlP9jQwlxPAWFo2nrael7c91TCNGgU45oa7NYE+GE 2O7nCov2sjdSikql/k+ATLDdZWRkK9DGH2ZvIl+5zRYgp6Y6yMnNr//LtgqPMyZAbqU1 udJdUrLBFN0lwjBrWs2msL422HP6pWkJaYGksJ26rAI+c009jeYXA/ANQk/nLjW7dujt dGs315/6jhXKFHeXYFjTQRDTqUxlgkjQYdpc+A9y6RZEnqJzYtbl+51/t5UXWv3Llb+C VPJQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d20si4978190edn.502.2020.04.30.02.59.44; Thu, 30 Apr 2020 03:00:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726692AbgD3J4E (ORCPT + 99 others); Thu, 30 Apr 2020 05:56:04 -0400 Received: from foss.arm.com ([217.140.110.172]:51616 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726404AbgD3J4D (ORCPT ); Thu, 30 Apr 2020 05:56:03 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 14DCE1063; Thu, 30 Apr 2020 02:56:03 -0700 (PDT) Received: from bogus (unknown [10.37.12.118]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 928963F68F; Thu, 30 Apr 2020 02:56:01 -0700 (PDT) Date: Thu, 30 Apr 2020 10:55:59 +0100 From: Sudeep Holla To: Xiongfeng Wang Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, guohanjun@huawei.com, john.garry@huawei.com, Sudeep Holla Subject: Re: [RFC PATCH] cpufreq: add support for HiSilicon SoC HIP09 Message-ID: <20200430095559.GB28579@bogus> References: <1588227599-46438-1-git-send-email-wangxiongfeng2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1588227599-46438-1-git-send-email-wangxiongfeng2@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 30, 2020 at 02:19:59PM +0800, Xiongfeng Wang wrote: > HiSilicon SoC has a separate System Control Processor(SCP) dedicated for > clock frequency adjustment and has been using the cpufreq driver > 'cppc-cpufreq'. New HiSilicon SoC HIP09 add support for CPU Boost, but > ACPI CPPC doesn't support this. In HiSilicon SoC HIP09, each core has > its own clock domain. It is better for the core itself to adjust its > frequency when we require fast response. In this patch, we add a > separate cpufreq driver for HiSilicon SoC HIP09. > I disagree with this approach unless you have tried to extend the CPPC in ACPI to accommodate this boost feature you need. Until you show those efforts and disagreement to do that from ASWG, I am NACKing this approach. -- Regards, Sudeep