Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 30 Apr 2020 11:59:13 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Reinette Chatre <reinette.chatre@intel.com>
Cc:     tglx@linutronix.de, fenghua.yu@intel.com, tony.luck@intel.com,
        kuo-lang.tseng@intel.com, mingo@redhat.com, babu.moger@amd.com,
        hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86/resctrl: Support CPUID enumeration of MBM
 counter width
Message-ID: <20200430095913.GA3996@zn.tnic>
References: <cover.1585763047.git.reinette.chatre@intel.com>
 <76dc65631c373e0c1c9f3e8aaa768f022a2c989c.1585763047.git.reinette.chatre@intel.com>
 <20200429181149.GE16407@zn.tnic>
 <6fb58472-88f2-925b-3a4e-4692957a9582@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <6fb58472-88f2-925b-3a4e-4692957a9582@intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 29, 2020 at 11:42:03AM -0700, Reinette Chatre wrote:
> This would essentially be resubmitting [1] though. Do you expect that
> this change would receive a different reception at this time?

Right, Thomas and I talked it over a bit last night. So the proper
thing to do is to read all that information *once* and put it in
boot_cpu_data. Because that information is replicated the same over
CPUID on each core. If there's per-CPU stuff, then it should remain
per-CPU but looking at how the RDT code uses boot_cpu_data, I'd say this
is global info.

So, it should be parsed once on the BSP during boot and put into
boot_cpu_data. And then silly stuff like x86_init_cache_qos() should go
away too.

If this info is needed on Intel only, then it should be parsed in
cpu/intel.c, in a ->c_bsp_init helper and if it is needed on AMD too,
then a function which does this should be called by the respective
c_bsp_init helper.

Then all its users can continue reading it out of boot_cpu_data and
future RDT hw info can be added there.

Makes sense?

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette