Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v7 3/7] tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()"
To:     Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc:     Eyal.Cohen@nuvoton.com, oshrialkoby85@gmail.com,
        alexander.steffen@infineon.com, robh+dt@kernel.org,
        mark.rutland@arm.com, peterhuewe@gmx.de, jgg@ziepe.ca,
        arnd@arndb.de, gregkh@linuxfoundation.org, benoit.houyere@st.com,
        eajames@linux.ibm.com, joel@jms.id.au, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
        oshri.alkoby@nuvoton.com, tmaimon77@gmail.com, gcwilson@us.ibm.com,
        kgoldman@us.ibm.com, Dan.Morav@nuvoton.com,
        oren.tanami@nuvoton.com, shmulik.hager@nuvoton.com,
        amir.mizinski@nuvoton.com
References: <20200427124931.115697-1-amirmizi6@gmail.com>
 <20200427124931.115697-4-amirmizi6@gmail.com>
 <20200429053703.GF8452@linux.intel.com>
From:   Amir Mizinski <amirmizi6@gmail.com>
Message-ID: <41fd551b-e678-32bb-781d-48cfe1a3c5bb@gmail.com>
Date:   Thu, 30 Apr 2020 10:29:08 +0000
User-Agent: Mozilla/5.0 (X11; Linux armv7l; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200429053703.GF8452@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2020-04-29 05:37, Jarkko Sakkinen wrote:
> On Mon, Apr 27, 2020 at 03:49:27PM +0300, amirmizi6@gmail.com wrote:
>> From: Amir Mizinski <amirmizi6@gmail.com>
>>
>> Using this function while reading/writing data resulted in an aborted
>> operation.
>> After investigating the issue according to the TCG TPM Profile (PTP)
>> Specifications, I found that "request to cancel" should occur only if
>> TPM_STS.commandReady bit is lit.
>> Note that i couldn't find a case where the present condition
>> (in the linux kernel) is valid, so I'm removing the case for
>> "TPM_VID_WINBOND" since we have no need for it.
>>
>> Also, the default comparison is wrong. Only cmdReady bit needs to be
>> compared instead of the full lower status register byte.
>>
>> Fixes: 1f86605 (tpm: Fix cancellation of TPM commands (polling mode))
>
> Needs to have exactly 12 hex digits of the hash.
>

Ok, i'll fix this for version 8. Thank you.

> /Jarkko