Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1695701ybz; Thu, 30 Apr 2020 04:00:27 -0700 (PDT) X-Google-Smtp-Source: APiQypKmIt3mtbkGrazHaBoY19LygDZnKKkO3+G62+1YAhMDPRogbAROjMZK83HGQula6mkasfEW X-Received: by 2002:a17:907:447f:: with SMTP id oo23mr2067296ejb.274.1588244427161; Thu, 30 Apr 2020 04:00:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588244427; cv=none; d=google.com; s=arc-20160816; b=pD8lvCFwjzTkdpQW+ptNike+FDmY28Y32bYeFrmGid7h2LYHoZ52Ti9FRYBMMwWflk qtxpPxdDd2oiR4x/iYa+du1C5+1T1U1jN3ii4GiXma4SHVmBp6gSqX1f6d7iljgaiZs1 Rb/HUgj9YuK7Fxv15U3S0wJTtxbFabdBiz7t73d6EJeAlVT0gYCfj43An5p7cEjedNW+ icOYwUJWM5pgvnQTcq09RoBV8abKZzMI+J10F3BFS/v2+3yPGJcRCcCPvJskqkUqiIIH v+IizVtkl+LgZOg2W48xcfOPJ0dncieMi2cAuyxtJHI0+CsWrQYfw0SEN/xgDNfH7dkg Grlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=hqnS0EZKmLSfZLZ3uY7UEJZiNqdelH6M/RZx1FeDUas=; b=lsLtEECo7wvV8DWJbuBkWmuYJrhrH/2KjgTIqkAGl0+rGtbR722qfOa8ClHCQtBp0T Wk1hl9fiGcHr2A1aegEnh09TN0pKd8a+tEMadwCQjpME9cLqwBZJeM6y4WjJ7nRKnjB0 afEbgo/hXY2LuFXeAOv2Mvk7xoca7/TD2JwUumIcoBtPol8c1KzbZdAo9rT66NYVhn6a S5auTDTVCbM9jXeVZt1LHdHTA2clb2H4zKqBSCURdgeL7WWziTWUjyPXLIGwOEwLUfBh n8VgUKStQ71fWVA6ZuITEaZ6bYj7fiilnVUR1kiTuGM/45K/UcnyOiLycMjW4DwoMY6c 49Ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u9si5335083ejr.55.2020.04.30.04.00.03; Thu, 30 Apr 2020 04:00:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726745AbgD3K4V (ORCPT + 99 others); Thu, 30 Apr 2020 06:56:21 -0400 Received: from kernel.crashing.org ([76.164.61.194]:50512 "EHLO kernel.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbgD3K4V (ORCPT ); Thu, 30 Apr 2020 06:56:21 -0400 Received: from localhost (gate.crashing.org [63.228.1.57]) (authenticated bits=0) by kernel.crashing.org (8.14.7/8.14.7) with ESMTP id 03UAtojD025184 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 30 Apr 2020 05:55:54 -0500 Message-ID: <232b9fac588beb4d024ab496b118c51af2b0ecba.camel@kernel.crashing.org> Subject: Re: [PATCH v0 linux master] i2c/busses: Avoid i2c interrupt status clear race condition. From: Benjamin Herrenschmidt To: Wolfram Sang , Ryan Chen Cc: Brendan Higgins , Joel Stanley , Andrew Jeffery , "linux-i2c@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Date: Thu, 30 Apr 2020 20:55:48 +1000 In-Reply-To: <20200429090355.GA2891@kunai> References: <20200429033737.2781-1-ryan_chen@aspeedtech.com> <20200429075357.GA1957@kunai> <56add9c6e6b5410986325a1360466e4b@TWMBX02.aspeed.com> <20200429090355.GA2891@kunai> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-04-29 at 11:03 +0200, Wolfram Sang wrote: > > And is there maybe a Fixes: tag for it? > > [Ryan Chen] Yes it is a fix patch. > > I meant this (from submitting-patches.rst): It fixes the original implementation of the driver basically. It's just a classic posted-write fix. The write to clear the pending interrupt is asynchronous, so you can get spurrious ones if you return from the handler before it has percolated to the HW. I assume it's just more visible on the 2600 because of the cores are significantly faster but the IO bus is still as dumb. Ryan: You could always add a Fixed-by: tag that specifies the commit that added the initial driver... Cheers, Ben.