Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200415162030.16414-1-sravanhome@gmail.com> <20200415162030.16414-3-sravanhome@gmail.com>
 <20200424071822.GM3612@dell> <8ff17d07-8030-fcfe-8d8a-3011e4077778@gmail.com>
 <20200424093720.GA3542@dell> <864eb6ad-a605-c0a0-c3e7-23c0c70f5ede@gmail.com>
 <20200424105319.GD8414@dell> <c62cd5f2-6d82-0a2a-5ee5-a3e99e188a05@gmail.com>
 <20200427085149.GF3559@dell> <6063ad6e-444c-b905-b858-d8f94d700748@gmail.com> <4585179d-826b-6240-38a2-18fe757bc810@gmail.com>
In-Reply-To: <4585179d-826b-6240-38a2-18fe757bc810@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 30 Apr 2020 14:07:59 +0300
Message-ID: <CAHp75Vf_PUQdcOVdao0KUjiLapicMOFHK6f5+gf-bi-k6hVgkA@mail.gmail.com>
Subject: Re: [PATCH v9 2/6] mfd: mp2629: Add support for mps battery charger
To:     saravanan sekar <sravanhome@gmail.com>
Cc:     Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald <pmeerw@pmeerw.net>,
        Sebastian Reichel <sre@kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 30, 2020 at 1:39 PM saravanan sekar <sravanhome@gmail.com> wrote:
> On 27/04/20 11:30 am, saravanan sekar wrote:
> > On 27/04/20 10:51 am, Lee Jones wrote:
> >> On Fri, 24 Apr 2020, saravanan sekar wrote:
> >>> On 24/04/20 12:53 pm, Lee Jones wrote:
> >>>> On Fri, 24 Apr 2020, saravanan sekar wrote:
> >>>>> On 24/04/20 11:37 am, Lee Jones wrote:
> >>>>>> On Fri, 24 Apr 2020, saravanan sekar wrote:

...

> >>>>>> Then how about using 'simple-mfd' and 'syscon'?
> >>>>>>
> >>>>>> Then you can omit this driver completely.
> >>>>> The exception is to support for non device tree platform as well,
> >>>>> but I have
> >>>>> tested only for ARM device tree platform.
> >>>> Is that a reality though?
> >>>>
> >>>> How else do you see this realistically being registered?
> >>>>
> >>> I understand that acpi related device table are not covered here,
> >>> well I
> >>> don't have to platform to test so.
> >>> If you ask me to cover acpi related table, I can do but hard to test.
> >> I don't know of any reasons why syscon can't be used by ACPI.
> >>
> >> Please try to solve this issue using 'simple-mfd' and 'syscon'.
> > Well the simple-mfd and syscon topic recommended by you when Device
> > tree alone is used.
> > I wounder still I receive review/improvements comments for this mfd
> > patch and also another
> > to omit this driver using simple-mfd (rework the series).
> > Confused, not sure which is valid and will be accepted at the end.
>
> I had look into syscon, as far my understanding syscon is supported only
> for memory mapped IO. MP2629
> device is over I2C bus, could you share your thought about syscon for
> this device?

My understanding too, but I didn't dug into it.
Something like general regmap support is missing (or I am missing the
way how to pass it to syscon).

-- 
With Best Regards,
Andy Shevchenko