Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1769372ybz; Thu, 30 Apr 2020 05:17:37 -0700 (PDT) X-Google-Smtp-Source: APiQypKUv9uG3O+PjhXCah3hfv6SG1QHtgZoq+N25RAAUttdxtf/9xRiGCKY2kUB2pHF0GRHlzyB X-Received: by 2002:a05:6402:6d5:: with SMTP id n21mr2450025edy.82.1588249057501; Thu, 30 Apr 2020 05:17:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588249057; cv=none; d=google.com; s=arc-20160816; b=Fy3QC6DM1A577edy9lzCeeaN/6ye5lKoOTetTthd+goZdf7hD6f3XCX7+L28YKyQoB BpFcpppItRsvy578E6AS9gZ6xMoSh9vOV0l9hXsBEy+DIqCqdQ7xo8lD2jG1grNZhG55 tz5Fz0lPHlkv2xSo3QjJA6j/f+6R8CpwObuD3HrG3CA1Cxs9yTMWb/XZtIvFEn09hTJb LVPjDbGd9h/WoI9omNvwO+cClsVuQTqGLzQWO+nwRWLhfLMesZ8CkFHUKfDAOFACSBi7 Q/EBqH37SEqEo5ysM5KXZs+3nXGmdaK9nj/4SsIQCSlv0jT6Cb1ExHkhtN6rVoBh7DNs xHTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=EzBuWm5JWT0BIY0z5srfSLrMp8Bzm7WqZbg9Gj/0C0M=; b=c/wLdBPaO8JNeIdpVkMclZtihrcx7Vu3ZxGyLZ8c3GTRxKh5357d2pj5OKMffzFRSj Sg4rGq2N3nNv0AsCTkSU/FpzQAqiBtss68fhMp4kGi1Tagbo7s9Z51QXbK5q28/5byeG 0KdCxmtfM6Puycy2WM4MkyQhMFISnnwvqU2LnzZcqmROzGQBPMKiHzf4S39ZTZUywlqP 1QJAblzFymj+uOPGfm05DsY4YvgeFLMkjnto7EMJ7f6lFj3BoBU/C4Qgpr6+SUVOG/LR 7qOI/hDr2g3nWPDzHIyR2a+zGzhfLfXj3Ys/hctkmsX69ekw5+KSOTmRuy8JFW24qMIX 63pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u3si5053689edq.473.2020.04.30.05.17.13; Thu, 30 Apr 2020 05:17:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726677AbgD3MPf (ORCPT + 99 others); Thu, 30 Apr 2020 08:15:35 -0400 Received: from cmccmta3.chinamobile.com ([221.176.66.81]:5142 "EHLO cmccmta3.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbgD3MPf (ORCPT ); Thu, 30 Apr 2020 08:15:35 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.9]) by rmmx-syy-dmz-app12-12012 (RichMail) with SMTP id 2eec5eaac1463c3-cd75d; Thu, 30 Apr 2020 20:15:04 +0800 (CST) X-RM-TRANSID: 2eec5eaac1463c3-cd75d X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.1.172.204]) by rmsmtp-syy-appsvr05-12005 (RichMail) with SMTP id 2ee55eaac146994-cdc8f; Thu, 30 Apr 2020 20:15:04 +0800 (CST) X-RM-TRANSID: 2ee55eaac146994-cdc8f From: Tang Bin To: davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Bin , Zhang Shengju Subject: [PATCH] net/faraday: Fix unnecessary check in ftmac100_probe() Date: Thu, 30 Apr 2020 20:15:31 +0800 Message-Id: <20200430121532.22768-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function ftmac100_probe() is only called with an openfirmware platform device. Therefore there is no need to check that the passed in device is NULL. Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin --- drivers/net/ethernet/faraday/ftmac100.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c index 6c247cbbd..2be173b03 100644 --- a/drivers/net/ethernet/faraday/ftmac100.c +++ b/drivers/net/ethernet/faraday/ftmac100.c @@ -1059,9 +1059,6 @@ static int ftmac100_probe(struct platform_device *pdev) struct ftmac100 *priv; int err; - if (!pdev) - return -ENODEV; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res) return -ENXIO; -- 2.20.1.windows.1