Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1771746ybz; Thu, 30 Apr 2020 05:20:02 -0700 (PDT) X-Google-Smtp-Source: APiQypLNbWfHeKrcDI9wGMlSfzgcgMk+ZHNOlC+nPD0ZfqZTj3P+4UbDWow9W5v/xA7AOq/lk48k X-Received: by 2002:a17:907:214f:: with SMTP id rk15mr2405450ejb.301.1588249202229; Thu, 30 Apr 2020 05:20:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588249202; cv=none; d=google.com; s=arc-20160816; b=Z63DX8gxORXRGlTOfN0Z+SGhVahMlXkHERFbnuzeRxJ1nQI46dHuoVqs+QFqsTnY2k bwQiAMDXKilZS9u+Vb4QN1UbOPTT9z4YqIRaWcYH8d8M/pksm8nAP+FAW/u3KkaAqAsl C5JbbhPj0cSgxAxOJdZtVjW0z4JE/Xer/NWzXcf5E9EribkhNl8lDqVLbUONPSatog/d rCDnMOxyTETezrPChQH3c0b/uF+HASyyXfzEWYt7fssY6irowJVzK1/HudgtDR8FgXOF HfFJXUypAzE9nX3Y2+JTT6qvdpIEnb7+/FZGsmjhYWRFZaK+emTrASKS574IGIhCphgC jdWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:to:from; bh=iGB7mrabcie7fnd/6EIZxOe6LKiJYZS5kB66ammVo/4=; b=bg94tLNITc60Cmf/jdF1+wLMjNb/ouLSXMs3FRPZJKNlLOaltJn7+isL81RgwmjQ64 dFruxYJ7fLPbwL3LXE5qD4A0earv13WlwF8KgwqMhdjMoA9s7TlRXSvtDi64cAMfm6Lk 6uyR2RFKxE8rY6p1fXhiww0ZxpFSHW/yO/OokoeWuPbSJ1V61Av/VfU0+xklQm0wsb94 aVqJnACIjKH6gHlNpABLGNCfWsc7MJZZjaiWq61PahNeDMuxz8TZV/E64RZlBxAROPlk pWQv48BR1kMXm4Qwa0bm421PjVi+bHRq0FK15zxSTPeU1cOhrrQbRTlJE7SgTJOPUjaK tZsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n10si6122525ejs.456.2020.04.30.05.19.39; Thu, 30 Apr 2020 05:20:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726871AbgD3MSE (ORCPT + 99 others); Thu, 30 Apr 2020 08:18:04 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:50036 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725280AbgD3MSE (ORCPT ); Thu, 30 Apr 2020 08:18:04 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id D86A06C30710E0D82DAD; Thu, 30 Apr 2020 20:18:02 +0800 (CST) Received: from huawei.com (10.175.124.28) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Thu, 30 Apr 2020 20:17:53 +0800 From: Jason Yan To: , , , , , , , Subject: [PATCH] scsi: fnic: use true,false for fnic->internal_reset_inprogress Date: Thu, 30 Apr 2020 20:17:18 +0800 Message-ID: <20200430121718.14970-1-yanaijie@huawei.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warning: drivers/scsi/fnic/fnic_scsi.c:2627:5-36: WARNING: Comparison of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/scsi/fnic/fnic_scsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index b60795893994..27535c90b248 100644 --- a/drivers/scsi/fnic/fnic_scsi.c +++ b/drivers/scsi/fnic/fnic_scsi.c @@ -2624,8 +2624,8 @@ int fnic_host_reset(struct scsi_cmnd *sc) unsigned long flags; spin_lock_irqsave(&fnic->fnic_lock, flags); - if (fnic->internal_reset_inprogress == 0) { - fnic->internal_reset_inprogress = 1; + if (!fnic->internal_reset_inprogress) { + fnic->internal_reset_inprogress = true; } else { spin_unlock_irqrestore(&fnic->fnic_lock, flags); FNIC_SCSI_DBG(KERN_DEBUG, fnic->lport->host, @@ -2654,7 +2654,7 @@ int fnic_host_reset(struct scsi_cmnd *sc) } spin_lock_irqsave(&fnic->fnic_lock, flags); - fnic->internal_reset_inprogress = 0; + fnic->internal_reset_inprogress = false; spin_unlock_irqrestore(&fnic->fnic_lock, flags); return ret; } -- 2.21.1