Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1776662ybz; Thu, 30 Apr 2020 05:25:17 -0700 (PDT) X-Google-Smtp-Source: APiQypJOZQdWIdnK6VATAN7XMe7Mkb4zyocjKm3jUf4yt+DVKJIZ0Q69zmxoT3EePFJWdivnFelP X-Received: by 2002:a05:6402:1757:: with SMTP id v23mr2437267edx.335.1588249517215; Thu, 30 Apr 2020 05:25:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588249517; cv=none; d=google.com; s=arc-20160816; b=SopEBPw+vAJ5nGoMrPhRXgwuZO4t67zXxR5kDsRLSlT1QU0HJInKMlNx6QgFHHSAoS Y+6lYsnFhGTZd4YIjPEljlLleY01B097Zk4Vth4umGe6qmLT7BJYMMlBtgsdKAqUVhvM BjtbEn3EeLB0Tzvn2PcZFfgHXuaCuGobFXY+SwI5Cjd4kbI/jQtV4EgnBcUhgMSZ418D lXDRFpeNBRLEmjLOKp6bvPtxDMSoF2YZ2oi2cBGyHYmzVqoN7f1iL7q2DbBYzhSKZLAs CISi6zohUJuE765P1dXkNl8u79Q2LQDZ79IXzOVU2LDLd9FVNsGtQtgRETWEH0IXreAE dFZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=s+u4WbOI6jCW0oIE7DyFq3VAR+Yi4wx9kBa1D0/SdQg=; b=maH6FYAj0UV5nrr7oUBrqCIK76rRDzYdcqE6K2bFjWeST+mleP9VsxbWtmmlHv+St6 CnJQaXx5RWxg7moFAVM/CxU6aYDG0ZLVQoYZKJg53SzjrhcHI8eFIy4iu1LwU4tApidT 6uFw2WEm8/rs5J7YjWMV7YOJRx0c/q/NOFG7WMSoVst1mSQcGLrxavOSmmbeaAMfmA6O iEXundQvWum9YbpJVmaPTZ3LAPpPjdt+zvquwrjcfRi6k4FroaEEoydZt6edEH00L+8O 23dsxwJ6GNWUUlaOfRxxQuMCcXaM9Q97aF4z8B/Ry420EbW0/V+gbF8Ljmyg1UCuTkAL zv2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mhgOxvO5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k25si5422241ejx.143.2020.04.30.05.24.52; Thu, 30 Apr 2020 05:25:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mhgOxvO5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726789AbgD3MX1 (ORCPT + 99 others); Thu, 30 Apr 2020 08:23:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:57980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726500AbgD3MX1 (ORCPT ); Thu, 30 Apr 2020 08:23:27 -0400 Received: from linux-8ccs.fritz.box (p3EE2CE96.dip0.t-ipconnect.de [62.226.206.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7DE382076D; Thu, 30 Apr 2020 12:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588249406; bh=s+u4WbOI6jCW0oIE7DyFq3VAR+Yi4wx9kBa1D0/SdQg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mhgOxvO5SzP0qyFjlsPvJqJqqlCQC1gkhUSEE3PFUKNYiTehOjao3zPe8AbRfqp1p uJiP7AjcSpDq+dUZMmPVdH79vT+q5tiO7b+IbSfVTv+dC5g7SI3LJy21McqaopMJt4 sDh98PHeCpSs7Vvx+ngCX2xBesWFf71Lv+vwgw+c= Date: Thu, 30 Apr 2020 14:23:22 +0200 From: Jessica Yu To: Miroslav Benes Cc: Josh Poimboeuf , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Joe Lawrence Subject: Re: [PATCH v4 11/11] module: Make module_enable_ro() static again Message-ID: <20200430122321.GA16620@linux-8ccs.fritz.box> References: <20200430111032.GA4436@linux-8ccs> <20200430114055.GA15426@linux-8ccs.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200430114055.GA15426@linux-8ccs.fritz.box> X-OS: Linux linux-8ccs 4.12.14-lp150.12.61-default x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Jessica Yu [30/04/20 13:40 +0200]: >+++ Miroslav Benes [30/04/20 13:35 +0200]: >>On Thu, 30 Apr 2020, Jessica Yu wrote: >> >>>+++ Josh Poimboeuf [29/04/20 10:24 -0500]: >>>>Now that module_enable_ro() has no more external users, make it static >>>>again. >>>> >>>>Suggested-by: Jessica Yu >>>>Signed-off-by: Josh Poimboeuf >>> >>>Thanks! Since this patch is separate from the rest and it's based on >>>modules-next, I can just take this last patch through the modules tree. >> >>It depends on 8/11 of the series. >> >>Acked-by: Miroslav Benes >> >>for the patch. > >Ah yeah, you are right (you meant patch 9/11 right)? Will take both >through modules-next. So I'm speaking nonsense apparently. I suggested taking them because the module patches were based on modules-next. But Miroslav correctly pointed out that these patches still depend on livepatch removing module_disable_ro() usage before we can even remove them from module.c. So ignore what I said earlier, the whole patchset should be applied together (I'm assuming the livepatching for-next branch). In any case, should there be any conflicts with modules-next they should be easy to resolve. Sorry for the noise! Jessica