To: linux-kernel@vger.kernel.org
From: "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 3/7] inflate pt1: clean up input logic
Date: Tue, 7 Mar 2006 15:26:05 -0800 (PST)
Organization: Mostly alphabetical, except Q, with we do not fancy
Message-ID: <dul4qd$100$1@terminus.zytor.com>
References: <0.399206195@selenic.com> <20060225180521.GB15276@flint.arm.linux.org.uk> <20060225210454.GL13116@waste.org> <20060225212247.GC15276@flint.arm.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
NNTP-Posting-Date: Tue, 7 Mar 2006 23:26:05 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1098
Lines: 27

Followup to:  <20060225212247.GC15276@flint.arm.linux.org.uk>
By author:    Russell King <rmk+lkml@arm.linux.org.uk>
In newsgroup: linux.dev.kernel
> 
> All these are to do with decompressing a compressed kernel.  If they
> fail, halting is perfectly reasonable because we probably don't have
> an executable kernel.  Your arguments are fine for these.  But, that's
> not the full story - there are two more places where this code is
> used:
> 
> init/do_mounts_rd.c:#include "../lib/inflate.c"
> init/initramfs.c:#include "../lib/inflate.c"
> 
> for these your arguments that halting is fine is _NOT_ correct nor is it
> desirable.  The first of these is the cause of the problems both myself
> and others saw, as detailed in the URL I posted previously in this thread.
> Did you read that post?
> 

These probably should use lib/zlib instead...

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/