Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1852123ybz; Thu, 30 Apr 2020 06:40:41 -0700 (PDT) X-Google-Smtp-Source: APiQypIzV9NoZgyDRV7VsRBbTbrmOgkaF8SEq6YwiRARSTIOwcpCA7B3V6pnJCn6whSshquznZYY X-Received: by 2002:a17:906:e5a:: with SMTP id q26mr2547254eji.261.1588254041365; Thu, 30 Apr 2020 06:40:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588254041; cv=none; d=google.com; s=arc-20160816; b=VRkM1TbvMxmNzgRcXzU1gIgjFevcJ/DoGKwORHB/fxfOuIe1YleG1QG82OUkhie+GZ 7mJfrN1tcT+Y0JFMN8OBGhJ4GIVZwvbjJZ8WL6ocdTVC7bD1ZKwpT0gKmfl50uVXVy8G JeCNl8I4ageU1FW8DCb2o6JYOfHluhiDmUxTP9/hpa+uvyHsLpJoWfWa9jvkamnPlI8c HSzJHhkOYOMTd2u3zS7vqL/oWp5vhlrZspaDoTRCyOpOlSkaNVZ0d7ltHFTZq03/Cnoz ppL6QV1VnOtlV0x2cCFsgJUaLfPthG7uXnLU4pyh0+3/TBV+tofwjqC+u7jFPlATFJk8 cwuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=B+WEF5edk3Tx9yanz1zjhNZZoZVcwwOPFtC6hwTP6dM=; b=PQ7r7iPD7oLIyVQHBn2Wtvnsc1w9YeOkjbO84HY4lpO0LPEWFCDdQCARuvlDHEz5Ru cyp72SR8gvAwu2Dx2piNlE781pRUhRnQvTcUD/xT9rvDu+wEOc1wtFv5CQRoOvrLPGcZ SVHsISplAWVCy7Z7npeB3/9lsmQJlM/srEd89bZZSaGPZNkjHFadew5X+3IvjOM0yfFc 3VkjPI6gP7q+Pv5GZONqXpGcJSzljyC8aOAVZyTPj9kOAeeqVMM+1+kLwUmAmpD6/kXN UObWJScg+e+6GJyCPgNWVVXlRfOg9KsS0XXmX9kggjxMp+65L8z5TjWVkAk/p8b2q7F7 2PAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MLbZulFw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y11si5313940edt.286.2020.04.30.06.40.18; Thu, 30 Apr 2020 06:40:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MLbZulFw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727769AbgD3Nil (ORCPT + 99 others); Thu, 30 Apr 2020 09:38:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726577AbgD3Nil (ORCPT ); Thu, 30 Apr 2020 09:38:41 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18462C035494; Thu, 30 Apr 2020 06:38:41 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id y3so1247305lfy.1; Thu, 30 Apr 2020 06:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=B+WEF5edk3Tx9yanz1zjhNZZoZVcwwOPFtC6hwTP6dM=; b=MLbZulFwsobx2KLyBx9iY3KB/SsuKASOCPvckS4/rEG0YLBxkXcxBOK4JwIrjClClW HM9xvsP96epewF1COZ3VhWvXZPn5ce/0+1mtDrLog+3LPgZ+P72mqOeDTEky2sDzw31k 4UstRsS9T9moos73+h10ZAwPxM9WAUV3ncUMgNeTtZSsPHbcgVZL4p2oQCOdaW0XnJl+ zUeq5Ekqkf6RD9CS6u6OIhZ2ySvqzWU1cbcukfDv4w+1fJpRsgZ82fL6qkcFWo7sLlk0 pWljap3l1bBcniTqo4PnxtDZcvyo2dSBUWE2FheFlcHGDsLCtHSw/M76g//dYLFny3l4 UWpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=B+WEF5edk3Tx9yanz1zjhNZZoZVcwwOPFtC6hwTP6dM=; b=T9JFTVzMDg4xcSNsJC43pfVqz8nD7p9krgFHRFmPqIVOdYkaM0PyNh3Mc5PJ/8Tg6K QrKZ7lFLioKRa0BbQcQ1xFFmbyqtWtcAPwcZq91/QirDf8Ebdcle7+A5DIQUQ5dnK3AH PQ6/gZW1HOMx17FvVo8kIs+p1P3mKeWw1bddj2mJSpFEGQR9CrWIKgYstf+LL929Y0lF N3fp7WxNv6px6d7CDcXR+9exjdPN9tLbDyJBbSDAIj1qraNpOCYuTXUe0qRYaL1caave Xaq9AjUYJPssysUSa5w/kYjFANkxugkundyO/Y+acXZ+aQwMkwlka4qvr2ks9Nnmdoh5 YLyQ== X-Gm-Message-State: AGi0PuarU/2dvc3oMEjq4OdIX2aB/R3SfNgSFO7Ew+xfUFT3+G5CiE3T ROLC+3TY6FxvNisEVt3GbavW4Enh X-Received: by 2002:a19:490b:: with SMTP id w11mr2253959lfa.9.1588253919346; Thu, 30 Apr 2020 06:38:39 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id q125sm4413979ljb.34.2020.04.30.06.38.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2020 06:38:38 -0700 (PDT) Subject: Re: [RFC PATCH v11 6/9] media: tegra: Add Tegra210 Video input driver To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, frankc@nvidia.com, hverkuil@xs4all.nl, sakari.ailus@iki.fi, helen.koike@collabora.com Cc: sboyd@kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <1588197606-32124-1-git-send-email-skomatineni@nvidia.com> <1588197606-32124-7-git-send-email-skomatineni@nvidia.com> From: Dmitry Osipenko Message-ID: <34a49a30-71f2-5b24-20a4-7d98ae37cefa@gmail.com> Date: Thu, 30 Apr 2020 16:38:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1588197606-32124-7-git-send-email-skomatineni@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 30.04.2020 01:00, Sowjanya Komatineni пишет: > +/** > + * struct tegra_csi_ops - Tegra CSI operations > + * > + * @csi_streaming: programs csi hardware to enable or disable streaming. > + * @csi_err_recover: csi hardware block recovery in case of any capture errors > + * due to missing source stream or due to improper csi input from > + * the external source. > + */ > +struct tegra_csi_ops { > + int (*csi_streaming)(struct tegra_csi_channel *csi_chan, u8 pg_mode, > + int enable); What about to split csi_streaming() into csi_start_streaming() / csi_stop_streaming()? This will make tegra_csi_ops to be consistent with the tegra_ve_ops. A separated start/stop operations are somewhat more natural to have in general.