Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1867961ybz; Thu, 30 Apr 2020 06:57:43 -0700 (PDT) X-Google-Smtp-Source: APiQypIE5ohbpTTWdVaW86zy1YKpuwtmhUnQViqk7xPx8QGgrGj4wWj3Cbx4RyIasbMMXMft1O1x X-Received: by 2002:a17:906:4c46:: with SMTP id d6mr2723666ejw.257.1588255063405; Thu, 30 Apr 2020 06:57:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588255063; cv=none; d=google.com; s=arc-20160816; b=nKdQSEa47uBUzGodiCRqXRQeM09Tczefx+5vnXKJbE4dvlDo20qTGAWeUw7/AF+asl ncaJ6wLUvGHJw3u0j05wdK1wiNW9civYsWmBYrt8GSzjqLuVKTyH0Al8wEVoOUYmomeU K6chV20Gr3YS6VnZxJSYZ2iLRg8f00ezy1SE3a2uEtL2ByFvR7g7u44pPKZNJiNcrpSr 3/vqqtMbV9Prpkkg09xg7QYPn2m6V3dqOJv+BBDUYddigKC3/wSqbsetX5b6KQ5qfU3o 2xLftiHl8bKkLHfiVBdWYeth1oZZI1CZSSazYQb2K0gcQ1TM3Ty/Ayd696OH8KQBmkp7 7I9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4UiKe60Gf+YyQ2sQq1v1pzWZmr0NvNOHwkREjRk2Thw=; b=nO7pgr0NQn/5uD2Tvt+p9u1OXDmJALjXeSCPnCwAAYG/1Xe8xjrIumxWiAVkagzK7H MlsBUbnfAH6DOlkLVczuzfwxOEyd+S1XHdlbPMn9YbHIHQfbhyqod48MSbXTGAFBNes9 uPhEw5CgQCfK8vEAWyZ9K4f5vphSSLSNeMnUhsZTs7J/Uda1T2FCcol6MGvb43JScA5u DHUvklYia15rO7wPTBCpLt2JC/7Yo8o0z426Q/ZrwLRo+EhSyToJWkoopl/trm+Euprh HRA5nfrem7FKesCHneeTkjx1TSmnLg/Dl96RJD3XirsYiYe4EOlnIV0ltEjHPFzEWrHc +Pag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vIKSmQad; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w18si5125116edr.474.2020.04.30.06.57.19; Thu, 30 Apr 2020 06:57:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vIKSmQad; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728589AbgD3NxB (ORCPT + 99 others); Thu, 30 Apr 2020 09:53:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:33756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726770AbgD3Nwe (ORCPT ); Thu, 30 Apr 2020 09:52:34 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 89E7024956; Thu, 30 Apr 2020 13:52:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588254754; bh=LNu0u4m1TpX1W4ZZjSTKvd48EX1thU7V29jKjQvWTMc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vIKSmQad2MdmAkFHv0XEozlv8HCZJ/6BBbb6YhQxu3ZKqUraDsWRGFrMekBjR5EcD LAp5n9Be9atpTacv4CvjO/M7iU4lQCSW0lzyfs13/KaWDw/RVJ+9jXdG208vWE2W5E pGEmpE4ueNCWqTHu3MLYlleteRMYlT2ubojI9W7g= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Amadeusz=20S=C5=82awi=C5=84ski?= , Mark Brown , Sasha Levin , alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.4 13/57] ASoC: topology: Fix endianness issue Date: Thu, 30 Apr 2020 09:51:34 -0400 Message-Id: <20200430135218.20372-13-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200430135218.20372-1-sashal@kernel.org> References: <20200430135218.20372-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Amadeusz Sławiński [ Upstream commit 26d87881590fd55ccdd8f829498d7b3033f81990 ] As done in already existing cases, we should use le32_to_cpu macro while accessing hdr->magic. Found with sparse. Signed-off-by: Amadeusz Sławiński Link: https://lore.kernel.org/r/20200415162435.31859-2-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/soc-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index 2d4a5a3058c41..65c91abb9462f 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -2559,7 +2559,7 @@ static int soc_valid_header(struct soc_tplg *tplg, } /* big endian firmware objects not supported atm */ - if (hdr->magic == SOC_TPLG_MAGIC_BIG_ENDIAN) { + if (le32_to_cpu(hdr->magic) == SOC_TPLG_MAGIC_BIG_ENDIAN) { dev_err(tplg->dev, "ASoC: pass %d big endian not supported header got %x at offset 0x%lx size 0x%zx.\n", tplg->pass, hdr->magic, -- 2.20.1