Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1886666ybz; Thu, 30 Apr 2020 07:13:50 -0700 (PDT) X-Google-Smtp-Source: APiQypK8adKMpuuL9PVbpP4YsOx2mQNnZkWO6YUqa3yqArQbOInCg4Le43smpHYFaa8E7/YyPgqr X-Received: by 2002:a17:906:138c:: with SMTP id f12mr2899237ejc.35.1588256029983; Thu, 30 Apr 2020 07:13:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588256029; cv=none; d=google.com; s=arc-20160816; b=mqaGZ1EJbdFHFOMFrhCk9wPzfIh1C0ytuRsVcLjlZYnrkb/Xy/IaIoeyCiuj72loSl 3uvFDpz/aXQQbcBLZRYyv1FGZKpLEgD2pwpDkZMV0ExkkmZQuTzwZAfwnUFIlVjy7Ush GW0gBQmHuevh2UdylJEco3BYK/qFWdFFQyEQiuC5/U/I51ECM12d10GGfvMgtnKVX0hB 9PYY0rTdPrMuL2IQRMZnLTTjTY6HIKl9djK0JtNOvzwREIcA7bRWtgtEnBAuECHyWh/y 8331LeAkjJcM/D0RjHa1uBgUhuYS734n8Pf6xSPrjc8t8qORHcdquZ5igUuyxYBjosY7 SlRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UgntQxqafGUTlKfXGMK3gI4R0BEsk79OXFMuYEGS6WQ=; b=WOTd1rK+k2I8aV+JeWMxyu5INp4YJGLaNKIBr9SCYbKDyOLz7EWJTT+mVWyrSL8tFJ DT6ylMpjfWvvLYw90bSYIa9wE+RNWtzqhcvmnHAgPHP963qDy3EeXigp7s4XSQ1tgGdD cvC0ZwF3vM/6Bkdm+6JunERmDhEJGna0i2uWqVpVUy/IudFTJ/9Fw0L92/rJxn8q8bxY nIDg3KtahYcF/I/0NzC+Ff4bDLbo4gcgxWU6g/KjrFlXlUiR7wY2ohVX0cSoKIos2bf+ Iy0ulgxd3FPjQJDETFNS0ounkRibUI4riSkXYAsG2TS1enevbBor6Fp65kaRvkdgKq3O am2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="rnMbCvu/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d9si6021688ejb.387.2020.04.30.07.13.26; Thu, 30 Apr 2020 07:13:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="rnMbCvu/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728303AbgD3OMJ (ORCPT + 99 others); Thu, 30 Apr 2020 10:12:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:59218 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727932AbgD3NvL (ORCPT ); Thu, 30 Apr 2020 09:51:11 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4554621775; Thu, 30 Apr 2020 13:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588254671; bh=UUerJjfHpwzmoAU169iQTTzVJIn8QWxF04p5YHMxj/4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rnMbCvu/rpeJ4MCupTQyBzL3lUCyoWwOVPRcPRAattMCrzHYPe3kIaxsjR+ZpGDir 706txQbJ3BYB7GUqSM7pQxrYrj0bugHcqlanWV+7caLwPb1S5Oc0rmz9AaEJadSSHz X+uY67Rhgs5qQrA2jVlWtXAqeugVZLC7Dz7ZgHMo= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Christian=20K=C3=B6nig?= , Andrey Grodzovsky , Kent Russell , Sasha Levin , dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.6 23/79] drm/scheduler: fix drm_sched_get_cleanup_job Date: Thu, 30 Apr 2020 09:49:47 -0400 Message-Id: <20200430135043.19851-23-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200430135043.19851-1-sashal@kernel.org> References: <20200430135043.19851-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christian König [ Upstream commit 8623b5255ae7ccaf276aac3920787bf575fa6b37 ] We are racing to initialize sched->thread here, just always check the current thread. Signed-off-by: Christian König Reviewed-by: Andrey Grodzovsky Reviewed-by: Kent Russell Link: https://patchwork.freedesktop.org/patch/361303/ Signed-off-by: Sasha Levin --- drivers/gpu/drm/scheduler/sched_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 60c4c6a1aac68..75737ec596141 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -687,7 +687,7 @@ drm_sched_get_cleanup_job(struct drm_gpu_scheduler *sched) */ if ((sched->timeout != MAX_SCHEDULE_TIMEOUT && !cancel_delayed_work(&sched->work_tdr)) || - __kthread_should_park(sched->thread)) + kthread_should_park()) return NULL; spin_lock_irqsave(&sched->job_list_lock, flags); -- 2.20.1