Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 30 Apr 2020 17:05:34 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Priit Laes <plaes@plaes.org>
Cc:     Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-sunxi@googlegroups.com
Subject: Re: [PATCH 1/4] clk: sunxi-ng: a10/a20: rewrite init code to a
 platform driver
Message-ID: <20200430150534.kbzfb7utpc7kswlv@gilmour.lan>
References: <20200417221730.555954-1-plaes@plaes.org>
 <20200417221730.555954-2-plaes@plaes.org>
 <20200420124935.asfbgv7envb2af55@gilmour.lan>
 <20200420203228.GA4734@plaes.org>
 <20200429143510.ksi27lok2udtmfas@gilmour.lan>
 <20200430062137.GA32281@plaes.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="xtai2ger2274pycp"
Content-Disposition: inline
In-Reply-To: <20200430062137.GA32281@plaes.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--xtai2ger2274pycp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 30, 2020 at 06:21:37AM +0000, Priit Laes wrote:
> On Wed, Apr 29, 2020 at 04:35:10PM +0200, Maxime Ripard wrote:
> > On Mon, Apr 20, 2020 at 08:32:28PM +0000, Priit Laes wrote:
> > > On Mon, Apr 20, 2020 at 02:49:35PM +0200, Maxime Ripard wrote:
> > > > On Sat, Apr 18, 2020 at 01:17:27AM +0300, Priit Laes wrote:
> > > > > In order to register regmap for sun7i CCU, there needs to be
> > > > > a device structure already bound to the CCU device node.
> > > > >=20
> > > > > Convert the sun4i/sun7i CCU setup to platform driver to use
> > > > > it later as platform device.
> > > > >=20
> > > > > Signed-off-by: Priit Laes <plaes@plaes.org>
> > > >=20
> > > > You can't relly do that though. We have timers that need those cloc=
ks before the
> > > > device model is initialized.
> > >=20
> > > Ok, I'm somewhat lost now... are these the affected timers on sun7i f=
ollowing:
> > > - allwinner,sun4i-a10-timer (timer@1c20c00)
> > > - allwinner,sun7i-a20-hstimer (hstimer@1c60000)
> >=20
> > Yep
> >=20
> > > Any ideas on what approach I could actually use?
> >=20
> > I guess you could keep the CLK_OF_DECLARE registration, and then have a
> > platform_driver probe and register the regmap?
> >=20
>=20
> Thanks this did the trick.
>=20
> > > Also, similar timer dependency would affect then sun6i-a31 and sun9i-=
a80
> > > platforms too...
>=20
> I didn't check this before, but sun9i-a80 CCU is initialized currently via
> platform device. Should it be converted first to clock driver (CLK_OF_DEC=
LARE)?

I guess we could just remove the timer node on the A80. It has never been t=
ested
and never worked if the clock driver is probed through a platform device.

Maxime

--xtai2ger2274pycp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXqrpPgAKCRDj7w1vZxhR
xZyFAQCqSDmhn4yTFm8ud90F6phEUSQWgV3icAt09/kyc3T/TQEAmigbqqP2h2Ds
T2DQvJTkIn+f7Aa8y8JYzfr9iLPhsAA=
=Rpgl
-----END PGP SIGNATURE-----

--xtai2ger2274pycp--