Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAAOTY_86d-UryKQrLy8-zjTbrTRrHL4k3x=bx1KqvWxPL5jj2Q@mail.gmail.com>
 <AOsApgASCAa7imxfuvZwXqq0.3.1588228291133.Hmail.bernard@vivo.com>
In-Reply-To: <AOsApgASCAa7imxfuvZwXqq0.3.1588228291133.Hmail.bernard@vivo.com>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Thu, 30 Apr 2020 23:50:38 +0800
Message-ID: <CAAOTY_8o239n_y4LJiyU5978e87knZmNRJwSHZbEDxLLasiJjw@mail.gmail.com>
Subject: Re: Re: [PATCH] drm/mediatek: cleanup coding style in mediatek a bit
To:     Bernard <bernard@vivo.com>
Cc:     Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        opensource.kernel@vivo.com, David Airlie <airlied@linux.ie>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, Bernard:

Bernard <bernard@vivo.com> =E6=96=BC 2020=E5=B9=B44=E6=9C=8830=E6=97=A5 =E9=
=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=882:32=E5=AF=AB=E9=81=93=EF=BC=9A
>
>
>
> =E5=8F=91=E4=BB=B6=E4=BA=BA=EF=BC=9AChun-Kuang Hu <chunkuang.hu@kernel.or=
g>
> =E5=8F=91=E9=80=81=E6=97=A5=E6=9C=9F=EF=BC=9A2020-04-29 22:22:50
> =E6=94=B6=E4=BB=B6=E4=BA=BA=EF=BC=9ABernard Zhao <bernard@vivo.com>
> =E6=8A=84=E9=80=81=E4=BA=BA=EF=BC=9AChun-Kuang Hu <chunkuang.hu@kernel.or=
g>,Philipp Zabel <p.zabel@pengutronix.de>,David Airlie <airlied@linux.ie>,D=
aniel Vetter <daniel@ffwll.ch>,Matthias Brugger <matthias.bgg@gmail.com>,DR=
I Development <dri-devel@lists.freedesktop.org>,Linux ARM <linux-arm-kernel=
@lists.infradead.org>,"moderated list:ARM/Mediatek SoC support" <linux-medi=
atek@lists.infradead.org>,linux-kernel <linux-kernel@vger.kernel.org>,opens=
ource.kernel@vivo.com
> =E4=B8=BB=E9=A2=98=EF=BC=9ARe: [PATCH] drm/mediatek: cleanup coding style=
 in mediatek a bit>Hi, Bernard:
> >
> >Bernard Zhao <bernard@vivo.com> =E6=96=BC 2020=E5=B9=B44=E6=9C=8827=E6=
=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=883:53=E5=AF=AB=E9=81=93=EF=BC=9A
> >>
> >> This code change is to make code bit more readable.
> >> Optimise array size align to HDMI macro define.
> >> Add check if len is overange.
> >
> >One patch should just do one thing, but this do three things.
> >So break this into three patches.
> >
> >Regards,
> >Chun-Kuang.
>
> Hi
> This optimization is mainly to make the code a bit readable.
> These modifications are related, main in several related function calls i=
n the same file.
> I was a bit confused that if it is really necessary to change to three se=
parate patch submissions?
>
> Regards
> Bernard
>
> >>
> >> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> >> ---
> >>  drivers/gpu/drm/mediatek/mtk_hdmi.c | 22 +++++++++++-----------
> >>  1 file changed, 11 insertions(+), 11 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/med=
iatek/mtk_hdmi.c
> >> index ff43a3d80410..40fb5154ed5d 100644
> >> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> >> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> >> @@ -311,15 +311,15 @@ static void mtk_hdmi_hw_send_info_frame(struct m=
tk_hdmi *hdmi, u8 *buffer,
> >>         u8 checksum;
> >>         int ctrl_frame_en =3D 0;
> >>
> >> -       frame_type =3D *buffer;
> >> -       buffer +=3D 1;
> >> -       frame_ver =3D *buffer;
> >> -       buffer +=3D 1;
> >> -       frame_len =3D *buffer;
> >> -       buffer +=3D 1;
> >> -       checksum =3D *buffer;
> >> -       buffer +=3D 1;
> >> +       frame_type =3D *buffer++;
> >> +       frame_ver =3D *buffer++;
> >> +       frame_len =3D *buffer++;
> >> +       checksum =3D *buffer++;

This part looks like cleanup, so keep in this patch.

> >>         frame_data =3D buffer;
> >> +       if ((frame_len + HDMI_INFOFRAME_HEADER_SIZE) > len) {
> >> +               dev_err(hdmi->dev, "Wrong frame len: %d\n", frame_len;
> >> +               return;

This is error checking, not cleanup the coding style, so move this to
another patch.

> >> +       }
> >>
> >>         dev_dbg(hdmi->dev,
> >>                 "frame_type:0x%x,frame_ver:0x%x,frame_len:0x%x,checksu=
m:0x%x\n",
> >> @@ -982,7 +982,7 @@ static int mtk_hdmi_setup_avi_infoframe(struct mtk=
_hdmi *hdmi,
> >>                                         struct drm_display_mode *mode)
> >>  {
> >>         struct hdmi_avi_infoframe frame;
> >> -       u8 buffer[17];
> >> +       u8 buffer[HDMI_INFOFRAME_HEADER_SIZE + HDMI_AVI_INFOFRAME_SIZE=
];

This is to symbolize the number, symbolization is more than cleanup.

Regards,
Chun-Kuang.

> >>         ssize_t err;
> >>
> >>         err =3D drm_hdmi_avi_infoframe_from_display_mode(&frame,
> >> @@ -1008,7 +1008,7 @@ static int mtk_hdmi_setup_spd_infoframe(struct m=
tk_hdmi *hdmi,
> >>                                         const char *product)
> >>  {
> >>         struct hdmi_spd_infoframe frame;
> >> -       u8 buffer[29];
> >> +       u8 buffer[HDMI_INFOFRAME_HEADER_SIZE + HDMI_SPD_INFOFRAME_SIZE=
];
> >>         ssize_t err;
> >>
> >>         err =3D hdmi_spd_infoframe_init(&frame, vendor, product);
> >> @@ -1031,7 +1031,7 @@ static int mtk_hdmi_setup_spd_infoframe(struct m=
tk_hdmi *hdmi,
> >>  static int mtk_hdmi_setup_audio_infoframe(struct mtk_hdmi *hdmi)
> >>  {
> >>         struct hdmi_audio_infoframe frame;
> >> -       u8 buffer[14];
> >> +       u8 buffer[HDMI_INFOFRAME_HEADER_SIZE + HDMI_AUDIO_INFOFRAME_SI=
ZE];
> >>         ssize_t err;
> >>
> >>         err =3D hdmi_audio_infoframe_init(&frame);
> >> --
> >> 2.26.2
> >>
> >>
> >> _______________________________________________
> >> Linux-mediatek mailing list
> >> Linux-mediatek@lists.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek