Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200428110253.1.I926f6741079cafb04ecb592130aef75b24ad31ae@changeid>
 <c57b0892-d68d-f0f2-3cc1-b8549983227e@collabora.com> <CAONX=-dLVBpz+p1si4cWGHEmQ_toO8kW=fCPcdUuX2KLc-o=2A@mail.gmail.com>
 <CAONX=-dDWjMQDGncSgXNf86Bt3C5OUtFqh=Pe2HToGPSv5qa4A@mail.gmail.com>
 <CACeCKacoEjQm0_VfZGYNEZVhKubPyqspNZupQk+7piJOsVzH+Q@mail.gmail.com> <fc7901ff-9e67-d6d5-f084-70233fd8344c@collabora.com>
In-Reply-To: <fc7901ff-9e67-d6d5-f084-70233fd8344c@collabora.com>
From:   Prashant Malani <pmalani@chromium.org>
Date:   Thu, 30 Apr 2020 09:17:03 -0700
Message-ID: <CACeCKafnrMk_=Udg-roEbrkDzZe6m3mUk14OOVVROmn-agfpDA@mail.gmail.com>
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Handle NULL EC pointer
 during probe.
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc:     Daniil Lunev <dlunev@chromium.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Enric,

On Thu, Apr 30, 2020 at 8:26 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Prashant,
>
> On 30/4/20 2:43, Prashant Malani wrote:
> > On Wed, Apr 29, 2020 at 5:38 PM Daniil Lunev <dlunev@chromium.org> wrot=
e:
> >>
> >> [to make it appear on the mailing list as I didn't realize I was in
> >> hypertext sending mode]
> >>
> >> On Thu, Apr 30, 2020 at 10:11 AM Daniil Lunev <dlunev@chromium.org> wr=
ote:
> >>>
> >>> Hi Enric.
> >>> I encountered the issue on a Hatch device when trying running 5.4 ker=
nel on that. After talking to Prashant it seems that any device with corebo=
ot built before a certain point (a particular fix for device hierarchy in A=
CPI tables of Chrome devices which happened in mid-April) will not be able =
to correctly initialize the driver and will get a kernel panic trying to do=
 so.
> >
> > A clarifying detail here: This should not be seen in any current
> > *production* device. No prod device firmware will carry the erroneous
> > ACPI device entry.
> >
>
> Thanks for the clarification. Then, I don't think we need to upstream thi=
s. This
> kind of "defensive-programming" it's not something that should matter to =
upstream.

Actually, on second thought, I am not 100% sure about this:
Daniil, is the erroneous ACPI device on a *production* firmware for
this device (I'm not sure about the vintage of that device's BIOS)?

My apologies for the confusion, Enric and Daniil; but would be good to
get clarification from Daniil.

Best regards,
>
> Thanks,
>  Enric
>
>
> >>> Thanks,
> >>> Daniil
> >>>
> >>> On Thu, Apr 30, 2020 at 7:58 AM Enric Balletbo i Serra <enric.balletb=
o@collabora.com> wrote:
> >>>>
> >>>> Hi Daniil,
> >>>>
> >>>> Thank you for the patch.
> >>>>
> >>>> On 28/4/20 3:02, Daniil Lunev wrote:
> >>>>> Missing EC in device hierarchy causes NULL pointer to be returned t=
o the
> >>>>> probe function which leads to NULL pointer dereference when trying =
to
> >>>>> send a command to the EC. This can be the case if the device is mis=
sing
> >>>>> or incorrectly configured in the firmware blob. Even if the situati=
on
> >>>>
> >>>> There is any production device with a buggy firmware outside? Or thi=
s is just
> >>>> for defensive programming while developing the firmware? Which devic=
e is
> >>>> affected for this issue?
> >>>>
> >>>> Thanks,
> >>>>  Enric
> >>>>
> >>>>> occures, the driver shall not cause a kernel panic as the condition=
 is
> >>>>> not critical for the system functions.
> >>>>>
> >>>>> Signed-off-by: Daniil Lunev <dlunev@chromium.org>
> >>>>> ---
> >>>>>
> >>>>>  drivers/platform/chrome/cros_ec_typec.c | 5 +++++
> >>>>>  1 file changed, 5 insertions(+)
> >>>>>
> >>>>> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/plat=
form/chrome/cros_ec_typec.c
> >>>>> index 874269c07073..30d99c930445 100644
> >>>>> --- a/drivers/platform/chrome/cros_ec_typec.c
> >>>>> +++ b/drivers/platform/chrome/cros_ec_typec.c
> >>>>> @@ -301,6 +301,11 @@ static int cros_typec_probe(struct platform_de=
vice *pdev)
> >>>>>
> >>>>>       typec->dev =3D dev;
> >>>>>       typec->ec =3D dev_get_drvdata(pdev->dev.parent);
> >>>>> +     if (!typec->ec) {
> >>>>> +             dev_err(dev, "Failed to get Cros EC data\n");
> >>>>> +             return -EINVAL;
> >>>>> +     }
> >>>>> +
> >>>>>       platform_set_drvdata(pdev, typec);
> >>>>>
> >>>>>       ret =3D cros_typec_get_cmd_version(typec);
> >>>>>