Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2187283ybz;
        Thu, 30 Apr 2020 12:25:33 -0700 (PDT)
X-Google-Smtp-Source: APiQypKxmbyQXPaDKsfpo18/YhpeE2BgGlWCs7gZTQnIVT1Ltz+q+ssmaVXVafgmw7Jf130U3+CV
X-Received: by 2002:a17:906:695:: with SMTP id u21mr4102520ejb.187.1588274733607;
        Thu, 30 Apr 2020 12:25:33 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1588274733; cv=none;
        d=google.com; s=arc-20160816;
        b=M5NH3P9IfyFltMBk4XaJapVf9P37elbG+z7esCuBMakol8bQ+gs0lHQUjYNpCBGdRP
         S5HSc8ZES/rH4UoN8QoQ4rAICZzJD4/gNq8dQ+Zx8ZIxnxtcdUqi1QPaC88I0YwzVBig
         EqTKxxc+DeRA/OoL9MfRPMLZoUF/LOovJpMlPhbNQf4yAdoVD3i7Ddf3IBmPJToH7Bx5
         HEqChszqKd33+TNvdg+KTZNzbR5tB1TgSJ1oa24198QeoQixTWxhtSXE9374vVsHovWH
         u41fdr9aiqs+lg0cVCYvJ4bn3kmsm5nTDLB9eifpcKhCdMcN2GLmUOUKZTTEiptgmvJg
         Bp0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=YbaBfz3aDyhnEGwjhItyxW7lTmiJWBbVqFr9RjKKn0w=;
        b=mx5ObZS+hEI2/ySoz6409JxZorwnU6H5Voq0ZwcSLvUfhayW4VPJN1WSBSmmTjak5V
         Uxcbc1LF12h52r4cG99vAN8nPSyyJVKJbw+EtJXmL7DMGwp5fF/w7XsGjnNYtwHoftbb
         LL9CxIT+CoAWAdLkmbZv1mSFZVWslfC1Yv1NheFrNr/Yib5MXL9y4WGX9KLOylqUiTsl
         /0RC9dMBe7kCo5y8A0MZPSW3+BomrVqOxMDIg3wnFPTdgGvGr1PArfjla+lIb43FP7Ot
         XikwWpBEoJf6I1vCSb3WrWDhjeiejQoWDL2YwyovoTdTFVRgR61ea3DdxstwNJhKTjPU
         LLbw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id 13si353718ejz.499.2020.04.30.12.25.07;
        Thu, 30 Apr 2020 12:25:33 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726835AbgD3TVK (ORCPT <rfc822;jaysonjohndmello@gmail.com>
        + 99 others); Thu, 30 Apr 2020 15:21:10 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50404 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726366AbgD3TVJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Apr 2020 15:21:09 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3687C035494;
        Thu, 30 Apr 2020 12:21:09 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 705451288F360;
        Thu, 30 Apr 2020 12:21:09 -0700 (PDT)
Date:   Thu, 30 Apr 2020 12:21:08 -0700 (PDT)
Message-Id: <20200430.122108.297281216730911159.davem@davemloft.net>
To:     tangbin@cmss.chinamobile.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        zhangshengju@cmss.chinamobile.com
Subject: Re: [PATCH] net/faraday: Fix unnecessary check in ftmac100_probe()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200430121532.22768-1-tangbin@cmss.chinamobile.com>
References: <20200430121532.22768-1-tangbin@cmss.chinamobile.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 30 Apr 2020 12:21:09 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Tang Bin <tangbin@cmss.chinamobile.com>
Date: Thu, 30 Apr 2020 20:15:31 +0800

> The function ftmac100_probe() is only called with an openfirmware
> platform device. Therefore there is no need to check that the passed
> in device is NULL.
> 
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

Applied.