Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2197377ybz; Thu, 30 Apr 2020 12:36:54 -0700 (PDT) X-Google-Smtp-Source: APiQypI1Uz3C/Q6Z8qsmKxd6tKx78slMqEhHzuzz1K8qZK+bahUngrzSaBjUs5FQs16IQPSA2ont X-Received: by 2002:a17:906:7f0d:: with SMTP id d13mr25485ejr.312.1588275414278; Thu, 30 Apr 2020 12:36:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588275414; cv=none; d=google.com; s=arc-20160816; b=MgoZWJ6fG09EUpqXleoeqY8/RiW0YrKw2Y6tQxjZ+j0m5GBDWvEJf+vkCCMcaqeEcA NKQm6+mm3g+BN29G9PYk3HpY3SmgXp6k9vfdtEK4IeBsK7hh5ZGfVvwp9O/L2CYJ4bBg BmsIJPqPuN2RCtHoOqd8oZbBpv1QPmsEIM38gB0KMlLAkO4YgtAYmTbqonnYKU1r/6xL BgfwAnToCmbqa2J3JB4WBuphPmE7nOfcKgcP9wKkcErw3fs1CK6lZ9GL5QMwsiKF4Zal ZtnRp+n/cFZI2a5KAaoB6KPAY5iDn4IwZydoC2lfBtZLzZU20zuJdsRrYAtD8fAKRToZ F+NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:references:cc:to:subject:from:ironport-sdr :ironport-sdr; bh=4gTR83uEkX6Os2+m7hKG0quFOxGqB+8f8E4iRfwwJ0I=; b=OCrDCJfoqpFcFqtuITzeWkQwb59aPnXfd8+NW0CyyrGPbTR3E9iIcYEe4kkLK+LS29 14re7x7UbeSrzNjV/LRet13LQKE1gV9ybGL1kUa6opTEa7umxmQZNFWh7T9NluR/FC81 7lJUzjzClMedDZ18vFcEC0Ps15oI+fFfiU6Vf4rk70QNbC5NxA9PHwiCBYlI0vtaHawM tdSjn4hcbnxtVXgJrRZ3pD9i0UQY9T5N5RfP0lx3LUt8r7Rcm0ErXykOWRjoz+BEvVdN FwwKlL1ZfR9cGgOCltGc/py+YGp8UTmL18i9twym9arUfU53QxnHNwdd2P3hEVNn3NXW a4xg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd22si325978edb.162.2020.04.30.12.36.31; Thu, 30 Apr 2020 12:36:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726960AbgD3Tcf (ORCPT + 99 others); Thu, 30 Apr 2020 15:32:35 -0400 Received: from mga04.intel.com ([192.55.52.120]:34003 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727778AbgD3Tcc (ORCPT ); Thu, 30 Apr 2020 15:32:32 -0400 IronPort-SDR: YfyNnwlponU4ZvqqFUk/m6OOaiTxL4hz8aA/64v9W4sETkGje64d9HAkQtks0Rov30DhBAgaqn ee+0a8S2azig== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 12:32:31 -0700 IronPort-SDR: qbP7bELUd3YdDmIK7rpWTWGP1m6vZ2Kt5/t96FsE4n1qznI4O1qEUj9ImpwE9T8bs8tB+Xt11A jLBGEA/DXQYQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,336,1583222400"; d="scan'208";a="261884344" Received: from dnlloyd-mobl.amr.corp.intel.com (HELO [10.255.231.251]) ([10.255.231.251]) by orsmga006.jf.intel.com with ESMTP; 30 Apr 2020 12:32:31 -0700 From: Dave Hansen Subject: Re: [PATCH v1 1/1] fs/splice: add missing callback for inaccessible pages To: Christian Borntraeger , Claudio Imbrenda , akpm@linux-foundation.org, jack@suse.cz, kirill@shutemov.name Cc: david@redhat.com, aarcange@redhat.com, linux-mm@kvack.org, frankja@linux.ibm.com, sfr@canb.auug.org.au, jhubbard@nvidia.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, peterz@infradead.org, sean.j.christopherson@intel.com References: <20200428225043.3091359-1-imbrenda@linux.ibm.com> <2a1abf38-d321-e3c7-c3b1-53b6db6da310@intel.com> Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <540f483f-5e58-f342-e771-9d90c4d3fb6a@intel.com> Date: Thu, 30 Apr 2020 12:32:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/30/20 11:12 AM, Christian Borntraeger wrote: > On 29.04.20 18:07, Dave Hansen wrote: >> On 4/28/20 3:50 PM, Claudio Imbrenda wrote: >>> If a page is inaccesible and it is used for things like sendfile, then >>> the content of the page is not always touched, and can be passed >>> directly to a driver, causing issues. >>> >>> This patch fixes the issue by adding a call to arch_make_page_accessible >>> in page_cache_pipe_buf_confirm; this fixes the issue. >> I spent about 5 minutes putting together a patch: >> >> https://sr71.net/~dave/intel/accessible.patch > You only set the page flag for compound pages. that of course leaves a big pile > of pages marked a not accessible, thus explaining the sendto trace and all kind > of other random traces. Ahh, nice catch! That does explain an oddity or two that I saw. > What do you see when you also do the SetPageAccessible(page); > in the else page of prep_new_page (order == 0). > (I do get > 10000 of these non compound page allocs just during boot). Yes, I see the same thing. I updated the patch and double-checked that it triggers properly with a socket-based sendfile().