Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2251812ybz; Thu, 30 Apr 2020 13:41:37 -0700 (PDT) X-Google-Smtp-Source: APiQypLP+NVmCjFtsQDuZ4RjI+gdxXkeVS2x+ualEO3U3MRqs1ysyKGR1dW0wfFOBqcM8Ctx8IXA X-Received: by 2002:a17:906:355b:: with SMTP id s27mr291520eja.184.1588279297285; Thu, 30 Apr 2020 13:41:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588279297; cv=none; d=google.com; s=arc-20160816; b=pBec6XIdlQTYuS9PX95RSmr6TPqR828VffWPWq+LqpViYox1MDBO1yz/MgH8pZOVaV q7zlDqBcCTLJylxCofn7Uy27XWol0WTCXVpUsxIfCgkEmqRZhV24nwAhv5rUzFQ7kK+K X6Cf0Q6wlxyrpumqofc2u+T3Ds26AVl9aFdJ6AAVymZ8v6PuDlX020RAUglLNh76/aoT m0zZL28487RKtdjC7lGzwQxB2MGtGYW3Fqnlw7P4/SHSHnog5mvpGQnqHgnsGE2p+7GU OL1yhiLgIVTdIP6C6YX7wom3mpEm+sWJFJTzMNzh4fCLUns4Ann2CZo3EPgrvBIHzZyk 4SoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=EtlsqJtQ7dQrXk3mcAKFklOV5vu1TeDFBn5DgeRAx6g=; b=r2KMnurBGe8c8tyXVjtrUS5oH2zM9BVXhsQq2A3zxHTCuYuQgdoUWUU3tgb7d7I65Q K32lhbskVrcuJPk2truYXTOqG2+5VU+8Nh3VlcJOyX6IHiphUkcMV9MWiPpu254SATPj 61C+UNyBzyGmFNY2yyBmZCEcpbHp9wNny5rjDKrwuJpDdGNJxcaFcxUI1InNPdXbJS0x GWifszOuNK+pq2/dcmjKW3Zwd/4D+56OtqE1LXQSWKFINhJeIcxMjWch/G64pqUaT8i8 lS7LR/zAwdxrtP+f5gKK1v69QWO5Wep8Ad2R12hZc8C5BLT2pvGdx0T/rj/dMABTD87K n/Rw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z18si421902edx.121.2020.04.30.13.41.14; Thu, 30 Apr 2020 13:41:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727875AbgD3Ui7 (ORCPT + 99 others); Thu, 30 Apr 2020 16:38:59 -0400 Received: from mga12.intel.com ([192.55.52.136]:48464 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727829AbgD3Ui5 (ORCPT ); Thu, 30 Apr 2020 16:38:57 -0400 IronPort-SDR: lZusXHh+1cYTJHMgl21wcLvJx1/xEevdtk7iL5Q44fii0f+0ezGgOYuHze1p3r8aGWCHH0PoNY iEx7Pey+Pg5A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 13:38:55 -0700 IronPort-SDR: raQpdC72YFymAIww5pBWhgwTlpswHIXh/yYnXb0jxGotejI0KfGe2RpyzN+m+jLvUgvh7ne7hF E5EUVtWuHrAw== X-IronPort-AV: E=Sophos;i="5.73,337,1583222400"; d="scan'208";a="459712118" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 13:38:54 -0700 From: ira.weiny@intel.com To: linux-kernel@vger.kernel.org, Andrew Morton , Christian Koenig , Huang Rui Cc: Ira Weiny , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Chris Zankel , Max Filippov , Dan Williams , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, dri-devel@lists.freedesktop.org Subject: [PATCH V1 08/10] arch/kmap: Don't hard code kmap_prot values Date: Thu, 30 Apr 2020 13:38:43 -0700 Message-Id: <20200430203845.582900-9-ira.weiny@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200430203845.582900-1-ira.weiny@intel.com> References: <20200430203845.582900-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ira Weiny To support kmap_atomic_prot() on all architectures each arch must support protections passed in to them. Change csky, mips, nds32 and xtensa to use their global kmap_prot value rather than a hard coded value which was equal. Signed-off-by: Ira Weiny --- arch/csky/mm/highmem.c | 2 +- arch/mips/mm/highmem.c | 2 +- arch/nds32/mm/highmem.c | 2 +- arch/xtensa/mm/highmem.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/csky/mm/highmem.c b/arch/csky/mm/highmem.c index 0aafbbbe651c..f4311669b5bb 100644 --- a/arch/csky/mm/highmem.c +++ b/arch/csky/mm/highmem.c @@ -32,7 +32,7 @@ void *kmap_atomic_high(struct page *page) #ifdef CONFIG_DEBUG_HIGHMEM BUG_ON(!pte_none(*(kmap_pte - idx))); #endif - set_pte(kmap_pte-idx, mk_pte(page, PAGE_KERNEL)); + set_pte(kmap_pte-idx, mk_pte(page, kmap_prot)); flush_tlb_one((unsigned long)vaddr); return (void *)vaddr; diff --git a/arch/mips/mm/highmem.c b/arch/mips/mm/highmem.c index 155fbb107b35..87023bd1a33c 100644 --- a/arch/mips/mm/highmem.c +++ b/arch/mips/mm/highmem.c @@ -29,7 +29,7 @@ void *kmap_atomic_high(struct page *page) #ifdef CONFIG_DEBUG_HIGHMEM BUG_ON(!pte_none(*(kmap_pte - idx))); #endif - set_pte(kmap_pte-idx, mk_pte(page, PAGE_KERNEL)); + set_pte(kmap_pte-idx, mk_pte(page, kmap_prot)); local_flush_tlb_one((unsigned long)vaddr); return (void*) vaddr; diff --git a/arch/nds32/mm/highmem.c b/arch/nds32/mm/highmem.c index f6e6915c0d31..809f8c830f06 100644 --- a/arch/nds32/mm/highmem.c +++ b/arch/nds32/mm/highmem.c @@ -21,7 +21,7 @@ void *kmap_atomic_high(struct page *page) idx = type + KM_TYPE_NR * smp_processor_id(); vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx); - pte = (page_to_pfn(page) << PAGE_SHIFT) | (PAGE_KERNEL); + pte = (page_to_pfn(page) << PAGE_SHIFT) | (kmap_prot); ptep = pte_offset_kernel(pmd_off_k(vaddr), vaddr); set_pte(ptep, pte); diff --git a/arch/xtensa/mm/highmem.c b/arch/xtensa/mm/highmem.c index f57a7770eb08..8c58c4c37033 100644 --- a/arch/xtensa/mm/highmem.c +++ b/arch/xtensa/mm/highmem.c @@ -48,7 +48,7 @@ void *kmap_atomic_high(struct page *page) #ifdef CONFIG_DEBUG_HIGHMEM BUG_ON(!pte_none(*(kmap_pte + idx))); #endif - set_pte(kmap_pte + idx, mk_pte(page, PAGE_KERNEL_EXEC)); + set_pte(kmap_pte + idx, mk_pte(page, kmap_prot)); return (void *)vaddr; } -- 2.25.1