Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp62861ybz; Thu, 30 Apr 2020 16:30:18 -0700 (PDT) X-Google-Smtp-Source: APiQypIJAU03savVWKxdjj+CANfkgX/ykZr3Eg7/sHgmfZrvx2peN23+5+8RIw107fUyZxcxhZVX X-Received: by 2002:aa7:c1ca:: with SMTP id d10mr1399582edp.152.1588289417956; Thu, 30 Apr 2020 16:30:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588289417; cv=none; d=google.com; s=arc-20160816; b=sCtLX/T9G92+uChEsGRybyhYz/zIhezPqKxuLNHdTHFBg3qPFYcWYSjCL8fciQAsOL Cu/RNuJEIyMJswMPIQivmymkKdiaogA+o4DqV8yAoByHyQUvGA44RxE77kxhtY6imfTU KSuyoKGwhj+FFPeMsBvIsgw9iHbwZn5UTvhMUbt/h9xBzTfQ426krmlJVIGIzHXH+662 YI747FqEoNf9eDaKta/VkDoGvb7vvXQa27CEymAwZ0fhLipvf5r14oX3eiJRyEVvwCpH HSPnGepP+nKM2pTlx+x3dcf4TbDHl9TE5zNgelp7hT/wpP0wG34+vKZwWrkcd8YpeyL9 Dy9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :ironport-sdr:ironport-sdr; bh=gwHK+aa9f9M64CFmY5/Y+FzIlBU4AM9/Mfz+iB5eQBw=; b=Jr7bMNp9L0iJkzogY7/RDuYNvfZ5Q/SfBokiuBbZdUujM16RIMwY1UZPksosgkqni9 V95TO7ZFfjtki3TGgPqXla6vbxQx3FzKtlWPiriWQFlsPZuBV7wlhzKnUZ5wk+5cwsg+ 8yi9tmfJtCt0PiUSM1kzNUsNANUXsBWALj6il4qzsLosYwWIyzeNtrJ1IYXGI40OWVm3 Tq+z88s7STLMf3vbxNcqUYFkXWE2ow4d4fQXRcG2wx7GkNyY7taWQBGxqcZFimahkg6z jOY9MQKeRM2C6jxNuO4l9JqRERorWuT7UVx7aqrb7pIoj4yjNHl/nPwrftUO3j94ZIHL 6asQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h5si687086ejx.174.2020.04.30.16.29.44; Thu, 30 Apr 2020 16:30:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726862AbgD3XY4 (ORCPT + 99 others); Thu, 30 Apr 2020 19:24:56 -0400 Received: from mga07.intel.com ([134.134.136.100]:45823 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726355AbgD3XY4 (ORCPT ); Thu, 30 Apr 2020 19:24:56 -0400 IronPort-SDR: wTVBduigOOVB0pZDrPe1jz28U8SmLa7yqs+lMt7ZCu/SEqEDQ+M00F5BYUkCJCJOjSFROKlQFS KA+J+kJ2Usyg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 16:24:55 -0700 IronPort-SDR: 8Ndi1Xo18oo7OwAtPFeXY5jAmHkUsD+Bs9gHkDbjURuHQLpaIR8F8ZBuEH+qdjEGnoe4vQu16o JlihN8EVxJwg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,337,1583222400"; d="scan'208";a="283029943" Received: from cctang1x-win8.gar.corp.intel.com ([10.251.149.196]) by fmsmga004.fm.intel.com with ESMTP; 30 Apr 2020 16:24:55 -0700 Message-ID: Subject: Re: [PATCH] ASoC: SOF: Update correct LED status at the first time usage of update_mute_led() From: Ranjani Sridharan To: Kai-Heng Feng , pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com, kai.vehmanen@linux.intel.com, daniel.baluta@nxp.com Cc: Mark Brown , Jaroslav Kysela , Takashi Iwai , Jaska Uimonen , "moderated list:SOUND - SOUND OPEN FIRMWARE (SOF) DRIVERS" , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Date: Thu, 30 Apr 2020 16:24:55 -0700 In-Reply-To: <20200430091139.7003-1-kai.heng.feng@canonical.com> References: <20200430091139.7003-1-kai.heng.feng@canonical.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-04-30 at 17:11 +0800, Kai-Heng Feng wrote: > At the first time update_mute_led() gets called, if channels are > already > muted, the temp value equals to led_value as 0, skipping the > following > LED setting. > > So set led_value to -1 as an uninitialized state, to update the > correct > LED status at first time usage. > > Fixes: 5d43001ae436 ("ASoC: SOF: acpi led support for switch > controls") > Signed-off-by: Kai-Heng Feng LGTM, thanks! Reviewed-by: Ranjani Sridharan