Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 30 Apr 2020 17:49:19 -0700 (PDT)
Message-Id: <20200430.174919.939495831904691325.davem@davemloft.net>
To:     Julia.Lawall@inria.fr
Cc:     richardcochran@gmail.com, kernel-janitors@vger.kernel.org,
        andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
        linux@armlinux.org.uk, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, eugene.volanschi@inria.fr
Subject: Re: [PATCH] dp83640: reverse arguments to list_add_tail
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1588276292-19166-1-git-send-email-Julia.Lawall@inria.fr>
References: <1588276292-19166-1-git-send-email-Julia.Lawall@inria.fr>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Julia Lawall <Julia.Lawall@inria.fr>
Date: Thu, 30 Apr 2020 21:51:32 +0200

> In this code, it appears that phyter_clocks is a list head, based on
> the previous list_for_each, and that clock->list is intended to be a
> list element, given that it has just been initialized in
> dp83640_clock_init.  Accordingly, switch the arguments to
> list_add_tail, which takes the list head as the second argument.
> 
> Fixes: cb646e2b02b27 ("ptp: Added a clock driver for the National Semiconductor PHYTER.")
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

This looks correct to me too.

Applied and queued up for -stable, thanks.