Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 30 Apr 2020 18:28:01 -0700
From:   Guru Das Srinagesh <gurus@codeaurora.org>
To:     Joe Perches <joe@perches.com>
Cc:     Lee Jones <lee.jones@linaro.org>, devicetree@vger.kernel.org,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
        David Collins <collinsd@codeaurora.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] mfd: Introduce QTI I2C PMIC controller
Message-ID: <20200501012801.GB28441@codeaurora.org>
Mail-Followup-To: Joe Perches <joe@perches.com>,
        Lee Jones <lee.jones@linaro.org>, devicetree@vger.kernel.org,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
        David Collins <collinsd@codeaurora.org>,
        linux-kernel@vger.kernel.org
References: <cover.1588115326.git.gurus@codeaurora.org>
 <5644dea146f8b49a5b827c56392ff916bfb343e9.1588115326.git.gurus@codeaurora.org>
 <20200429075010.GX3559@dell>
 <20200501011319.GA28441@codeaurora.org>
 <9844969151d1641a0bc68c1378b554d66cc0fcf9.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9844969151d1641a0bc68c1378b554d66cc0fcf9.camel@perches.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 30, 2020 at 06:18:18PM -0700, Joe Perches wrote:
> On Thu, 2020-04-30 at 18:13 -0700, Guru Das Srinagesh wrote:
> > On Wed, Apr 29, 2020 at 08:50:10AM +0100, Lee Jones wrote:
> > > On Tue, 28 Apr 2020, Guru Das Srinagesh wrote:
> > > > The Qualcomm Technologies, Inc. I2C PMIC Controller is used by
> > > > multi-function PMIC devices which communicate over the I2C bus.  The
> > > > controller enumerates all child nodes as platform devices, and
> > > > instantiates a regmap interface for them to communicate over the I2C
> > > > bus.
> []
> > > > diff --git a/drivers/mfd/qcom-i2c-pmic.c b/drivers/mfd/qcom-i2c-pmic.c
> []
> > > Please don't role your own debug helpers.
> > > 
> > > The ones the kernel provides are suitably proficient.
> > 
> > Sure. Would this be acceptable instead, with the custom string replaced by a
> > macro that the kernel provides?
> > 
> > 	#define pr_fmt(fmt) "%s: %s: " fmt, KBUILD_MODNAME, __func__
> 
> trivia:
> 
> It's almost always smaller object code to use
> the KBUILD_MODNAME as a fixed string instead of
> as a printf argument.
> 
> 	#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__

Thanks, duly noted :)

Thank you.

Guru Das.