Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp193002ybz; Thu, 30 Apr 2020 19:30:52 -0700 (PDT) X-Google-Smtp-Source: APiQypJuFFmLlHg0d4Lji3bkaqJ/5d/KOgy1qaHyak3zDJEtLqkGbHefNPbq+o/ce2Af9uhc+8Cd X-Received: by 2002:a50:f005:: with SMTP id r5mr1634881edl.376.1588300252172; Thu, 30 Apr 2020 19:30:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588300252; cv=none; d=google.com; s=arc-20160816; b=VA24zmK6CRdlP5eieq16OGqAHls3oVyFk0Szk8xTdTP7Irgsy0g+L4nA83moED7s7T rNA5R8x+1c5lzz2A1sgHl2JkQkGalSOagepC89CwjgJN3n+s/YPJGih69Ts6QAUHJhRl b43Q+ulhH3K5cS0cwrlUm7hJPwRtDfh9b8PhmEMkQvMpznosTdV3qjckWI5U5wjkYw9u o/9mnCUGheer8W66t5Kt+uTZsxjp9oQAS10qfn0S+tGkwc7HfJpjyDW2aN9gOBclOp3N 6lwj9IgMlH3NLKa8WZBucH1JrLXmD+vM8s0+HkFacvQEc4bxsjfF0Lir/TgJlnCbbBb3 QRmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=+bqrLgcGFCf99Uu0U3dlp7gViTjK7ah+NjB2S1m2Aik=; b=Rk5D+aaMJr456xpqpfKV6aPUxVFtI4Adgc8xb61DK2FIDIwGQ5iV4jK8Wi+YhJgUFY rvYsxJglU8ljKCblQ6WZvt2P3QD3J4V9MGWmOMCA6iE6K19Ylpb2WYK9rUrN0L8VXF78 jQgU+3xJbemAc+aVXFRWtFXVtPh6O7iOX8Ua6JYAjNd7tekx5Y5QgrhPg243/4kd6KAI Q0Qg/EQWe/uDa7HWRAOE/paD6n/6fYfMeq3LZRUPDRRCGFXyXoB8PGLf9wTeSf28ZbB8 /Uxu1EDzPxQyUvnn/mNim0EHDdbN5ZF57tXfGmntUVkfKz/6qSaavSEqrSes7X1JIpCH IkvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=C40FoaSb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fx7si914888ejb.149.2020.04.30.19.30.28; Thu, 30 Apr 2020 19:30:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=C40FoaSb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728096AbgEAC24 (ORCPT + 99 others); Thu, 30 Apr 2020 22:28:56 -0400 Received: from ozlabs.org ([203.11.71.1]:38821 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727949AbgEAC24 (ORCPT ); Thu, 30 Apr 2020 22:28:56 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49Cx5B5W4lz9sTP; Fri, 1 May 2020 12:28:46 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1588300133; bh=+bqrLgcGFCf99Uu0U3dlp7gViTjK7ah+NjB2S1m2Aik=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=C40FoaSbb6Q7wxAomTtdxarjIzmNFst3ymTI/G0w+2Kk4NeklpK6MsprW4aeFuOL/ TkwCTTk/7ic3XMxxS6CK/X3oa/bQeVyESN7G+SaFXOX7im9fHNKTrHsMKV+kWikDkZ F4EQg/axXQnDydjHMY8YK4m1w7/g6KQLwOau55AA3fV9h56VfUn56xpldCbghHJ2Ak 2N9znvLw+oscvvZuzcfTam9qWHZe31okh0MKjz+kAwW42XWB85OVqyucfXymD7ELvU m5F7EwikPo5WIhIxh6Mz3Olzdcc/jvC1qxexqP0q2olewhZMqGmdXIZmIE3aXRiBqJ 5a8C0skKdBJKw== From: Michael Ellerman To: ira.weiny@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Christian Koenig , Huang Rui Cc: Ira Weiny , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Chris Zankel , Max Filippov , Dan Williams , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH V1 00/10] Remove duplicated kmap code In-Reply-To: <20200430203845.582900-1-ira.weiny@intel.com> References: <20200430203845.582900-1-ira.weiny@intel.com> Date: Fri, 01 May 2020 12:29:00 +1000 Message-ID: <87imhge6c3.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ira.weiny@intel.com writes: > From: Ira Weiny > > The kmap infrastructure has been copied almost verbatim to every architecture. > This series consolidates obvious duplicated code by defining core functions > which call into the architectures only when needed. > > Some of the k[un]map_atomic() implementations have some similarities but the > similarities were not sufficient to warrant further changes. > > In addition we remove a duplicate implementation of kmap() in DRM. > > Testing was done by 0day to cover all the architectures I can't readily > build/test. I threw some powerpc builds at it and they all passed, so LGTM. cheers