Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp227909ybz; Thu, 30 Apr 2020 20:26:29 -0700 (PDT) X-Google-Smtp-Source: APiQypI9TDT+deOtrh643MIBkdC6Ghd420SwEvnKMigd+MYa7c2s+k8ICgjxuPn1eR1Vtiw3/DqV X-Received: by 2002:a50:cb84:: with SMTP id k4mr1891318edi.89.1588303589688; Thu, 30 Apr 2020 20:26:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588303589; cv=none; d=google.com; s=arc-20160816; b=E6AL/Aq5CuDcfDFO+4NASmy4MDUucJpowMIc/vfNUiP9fPBNXNOyppbGfM9dpgLwTw Q2Ou3JB6OmQZY99fj1B0xj2DPv9ph7KqMA34fmDbhOJZAXHnSkkq0dmInrDE904YoKaN Iz90HTYwm1vA30UuVS3j9myaBZ25tqOabCGDiPJuFpzqaw5HvjbZvZebzBv39OkcMbkF RjQN1Kd0podZGHhtfqb+v5f11+jbGLQyi95rbm4KDmbVyOCVtLD/hUB9Y0mjWrqHjixD zfwkdO/cOtS+nZklMkUJcQQHFDnQ73jCaw7hroL4+NhEG8Ye75AjvUxnSOciiWjxXSq+ 8kNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Yjv4xsRm/r7VaUJSi687DGyaP1AB3YiCzmH1YXFPdak=; b=TVgEhW+ft2W9BX48iDOXejuIgbOuP+YKbis6g2FVDNfbUqcyaMrJbWkhbzCGt5DLRx b3GFl4o39QOQb5PzhV2E2tFq6qysmde9tJGc7Bfuv1TvjAX93w+XkJVDw61qT9XYHwFa qRUaMyOISBP7mZNFIKpbE+fr4KF6nO1bghi8Ex7T6lDktLZv8sdObsTst9IAOqhyJvTd UqTU4/FYiJsEl44QK2JMGC+5aJ0KpDqY3wvCwnSf/76gZjVu9HvJxCRDldJNS3mEHEdo BPALyuxCgw/WEuHSL/PzybiYi93ffp+1rV/all68y850P2JhCJdpwEpakPt2CUQ/aQ3X 7Psw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de20si882808edb.451.2020.04.30.20.26.06; Thu, 30 Apr 2020 20:26:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728174AbgEADYX (ORCPT + 99 others); Thu, 30 Apr 2020 23:24:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728092AbgEADYX (ORCPT ); Thu, 30 Apr 2020 23:24:23 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6625FC035494; Thu, 30 Apr 2020 20:24:23 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1F03B12772F6A; Thu, 30 Apr 2020 20:24:23 -0700 (PDT) Date: Thu, 30 Apr 2020 20:24:22 -0700 (PDT) Message-Id: <20200430.202422.549223229334559883.davem@davemloft.net> To: christophe.jaillet@wanadoo.fr Cc: jonas.jensen@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] net: moxa: Fix a potential double 'free_irq()' From: David Miller In-Reply-To: <20200426205921.47714-1-christophe.jaillet@wanadoo.fr> References: <20200426205921.47714-1-christophe.jaillet@wanadoo.fr> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 30 Apr 2020 20:24:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET Date: Sun, 26 Apr 2020 22:59:21 +0200 > Should an irq requested with 'devm_request_irq' be released explicitly, > it should be done by 'devm_free_irq()', not 'free_irq()'. > > Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver") > Signed-off-by: Christophe JAILLET Applied, thank you.