Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp246721ybz; Thu, 30 Apr 2020 20:57:59 -0700 (PDT) X-Google-Smtp-Source: APiQypJyw/eaqNH5amhCZ3aDAbIZx3aLpwQ4/0Esnp2SUcDVVMKm6BCH8+F99pkMjDu6E+7+hf4I X-Received: by 2002:aa7:d718:: with SMTP id t24mr1957979edq.29.1588305479599; Thu, 30 Apr 2020 20:57:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588305479; cv=none; d=google.com; s=arc-20160816; b=IlWktZhj2Mwv0GT012hYunuh1EE1BNB5fmF7bWAC1gOgY6lIhAIFBw7/XziykDesg7 DO3lhLZS4t2C4MmCgXtqZdIItR5laWrr64P8idWcuKKXNTGGuAck6Hc7gDYNrZ7ZfR6i I7iomc5hr2Km3kiPnBZ2fMNGllddm5ydEiKuuutzwCwMOTCRLphArRW2uXk9jcnv3LTc mJmYhVP1bUwXzCPBWSiKGZpg+X3nbOopr8JGCyt80WMKvPq5ZERMahGV3f5Roo3HdC7S MxQ2MOx++goU7wnCAte5tkJBzyYwyFedS+YCM0fVwJLSjX9Slr7CsP8w41wPDT6KcQcL oOdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Xza/yjXHP/czxPxvLX9XBtcxXcpRLpn1l+UhvmC78j4=; b=EshxathvNJBNJb8bqMuEUk4VALgB10OYeAxh2PGr3gI5yhi8femLYUqwhQP8CtwGZ7 dCboYjvNM2xD7TZJ24IiWFr38eS/zHczasTH7bvYaemn+OHH6nmfy34yN3bNIMxqAT9c nTQH/pxiZe7WtfyDvgGjGB7EYEeN9FucoUynvpHIwEZmgEIEQWQUmYUDm6kCUBTVo+hD 8/XTvf+VEr5/kPqCVo45lsLAEyKg8S7Sxs494PD0DoJGPo8sRXIz2n0pe+zD547glbZi OB774u67uR5En4W2NfOdjUsdn4c0uDo9o2GH3+MdX/Uu+FjBo8FIAecHDM0d6p4E5asF 7zHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a24si961182eds.168.2020.04.30.20.57.36; Thu, 30 Apr 2020 20:57:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728277AbgEAD4I (ORCPT + 99 others); Thu, 30 Apr 2020 23:56:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728092AbgEAD4H (ORCPT ); Thu, 30 Apr 2020 23:56:07 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E6E0C035494; Thu, 30 Apr 2020 20:56:07 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id F280312777A8D; Thu, 30 Apr 2020 20:56:06 -0700 (PDT) Date: Thu, 30 Apr 2020 20:56:06 -0700 (PDT) Message-Id: <20200430.205606.219525759145278874.davem@davemloft.net> To: michael@walle.cc Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, linux@armlinux.org.uk Subject: Re: [PATCH net-next v2 2/4] net: phy: bcm54140: fix phy_id_mask From: David Miller In-Reply-To: <20200428230659.7754-2-michael@walle.cc> References: <20200428230659.7754-1-michael@walle.cc> <20200428230659.7754-2-michael@walle.cc> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 30 Apr 2020 20:56:07 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michael Walle Date: Wed, 29 Apr 2020 01:06:57 +0200 > Broadcom defines the bits for this PHY as follows: > { oui[24:3], model[6:0], revision[2:0] } > > Thus we have to mask the lower three bits only. > > Fixes: 6937602ed3f9 ("net: phy: add Broadcom BCM54140 support") > Signed-off-by: Michael Walle > Reviewed-by: Andrew Lunn > Reviewed-by: Florian Fainelli Applied.