Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp436700ybz; Fri, 1 May 2020 01:40:31 -0700 (PDT) X-Google-Smtp-Source: APiQypJbDGru0nOq8nz/umyvKQz8AuSgr9LXhpHmQffeeFBlu9DZIbpSMGY1YVFERp4aOw08TCQa X-Received: by 2002:a05:6402:558:: with SMTP id i24mr2430144edx.347.1588322430785; Fri, 01 May 2020 01:40:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588322430; cv=none; d=google.com; s=arc-20160816; b=pccFvpxZ72GXm2jm22FEeTfWKvZHLKW8muXeVIsM8eE3zUpsjTe06QX3CG0dy6ZwQ+ ldSQInBrYrdWJ8wYX/j+BZbqbqIeCcVQ/VM+xqoJwefe+ieBACxxKIbyIv12c9bNgU/I WzFOG6b9qPw2ykA52zIQI9fSayawps/Dee/itxhtR1YHhlLg8qS+O/3HQuGjniZaIuau U3C/0fqcvZMCq1mdZAm4HBRJk+MipWQkohYzN6f0yOcsQ35JUIstEC4FWyHjf6jOfxrD eA4/4inCLwp+/3iCXwABKUu7bNG0bgZoubfHj8eZxHlWPh0HLswnP0NE7OZH5qFUEXCK ks1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ivAc0pr0eeBU4LFi2n7IskmFCnoDA5E7SPMDero85g0=; b=XoCyYPqFfYMpms9TAHiHoEeAeEeUmIfDZwXXKn2TEM3Q8fP5vA+25QVFLw8BIn3Xg3 LnH1+ONdcOUm9YzIaRVen/RhoEyEkxhxjLKZrs/FRpCw9ocOVTi8HfyXj7o1N4R7CMR/ GD6cWdwnLyYNCGpAOpdJAc4dyeSmXhbF8eullXckwcK29SNDaVF6NhMM46a+Hwfnun17 2RyWtgj1TbB98n2ifn7jbuTQje2eUdHI8N4ilWLqOA6TocOjoDO2ndEgs45s9cf4J5oO D1GcvbjHSssOPUFb5CSANx7opELi2hN//syeDI8PF5427mW+iRj9mtAjndF46oA2dKpi jgXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Klz9DZlz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f15si1489815ejy.37.2020.05.01.01.40.07; Fri, 01 May 2020 01:40:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Klz9DZlz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728442AbgEAIie (ORCPT + 99 others); Fri, 1 May 2020 04:38:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728325AbgEAIid (ORCPT ); Fri, 1 May 2020 04:38:33 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7369CC035494; Fri, 1 May 2020 01:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ivAc0pr0eeBU4LFi2n7IskmFCnoDA5E7SPMDero85g0=; b=Klz9DZlz8E1SHv8vZTRD5G5yKU 2koBYs8LdXWlZqi3eHIAgRSPjtmRn86vJbPmmL76whHFL7HtOCwZ8NRbN9WmKvZ6ss18VsBjaEBk+ v4/Meb9+spfjpn3l1MAWguZ/V81zOZbgvrLpn02ZfM1BySvXJ2ufH+6cifcju1Yg94axXD0G04qw+ YtxLXqDOy10KT6TrKFgV34ZW1Zpkgn9yl/rF498MMc5WiDeobIUynSijdWgVI/JjUqtHII4gVb653 wuLotWqbKtES/7ftneQBY9DWqvfXLsbCsmktQNSTKXN1Gw/1PNWmln9ocIjhpi6Xppu9pWH1YbgCF Gt9X6UXA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jURBn-0004Yp-69; Fri, 01 May 2020 08:38:31 +0000 Date: Fri, 1 May 2020 01:38:31 -0700 From: Christoph Hellwig To: ira.weiny@intel.com Cc: linux-kernel@vger.kernel.org, Andrew Morton , Christian Koenig , Huang Rui , Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Thomas Gleixner , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Andy Lutomirski , Dan Williams , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Subject: Re: [PATCH V1 04/10] arch/kunmap: Remove duplicate kunmap implementations Message-ID: <20200501083831.GD27858@infradead.org> References: <20200430203845.582900-1-ira.weiny@intel.com> <20200430203845.582900-5-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430203845.582900-5-ira.weiny@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 30, 2020 at 01:38:39PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > All architectures do exactly the same thing for kunmap(); remove all the > duplicate definitions and lift the call to the core. > > This also has the benefit of changing kmap_unmap() on a number of > architectures to be an inline call rather than an actual function. > > Signed-off-by: Ira Weiny Looks good, Reviewed-by: Christoph Hellwig