Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp438188ybz; Fri, 1 May 2020 01:43:12 -0700 (PDT) X-Google-Smtp-Source: APiQypJD3z+RG0WJdD1H2XAL9gA+GWEMVamuMjzgfo7ko4qtPMfVGldHgvvqLEB3F9y9gxuR2xYr X-Received: by 2002:a17:906:4e50:: with SMTP id g16mr2225399ejw.338.1588322591972; Fri, 01 May 2020 01:43:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588322591; cv=none; d=google.com; s=arc-20160816; b=sVeBWVy2XnRWpetnhsp8F9riqTNzIWflkk9ubmlC4qEW9mRl2rfACRBX/KttIjDJ6f 3lvYJDNmIW0zxgNdDPyBopdJX/AXcB+W62lc+6+NEJXJ4Wq7HjHXZvxpFX3pv+s/nxQt PrTUNfhvpbovbyI/SfHho5COYcjroA4MZcEf12n7FvYjXXq4vsDhiDMNxHTBZKY9q6Jc lOmNvNIgEaI72uHk+8xcnjtuMgqsLcp5dYWXGrurGRWoocHracTuMmnFu8C3anKNF+Wi 5pogJkxn1lkd0WDfQ2vW+Fjh1y91LbW5GuBiEKuqtRkBntNxZeUBFoHCBLo7QbQ+6Pbv VMSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=f6i/xXj+8xtv4i22gfS0ySJPzU3clX0TdMX0edwFM/I=; b=avaz7Tq7WntjD16rFXO8MdQXE/U0exLIRbio7U0npH7DpOqCBQTp4z8HEXOQYi2YJg ngf1tJzCn8+8gdO7ia1bYtoD5/b98GnlU4NLcen7VwGP3cX12NrKKl4aSFbSlzWuR4oC v2leBhuUP2xbYARYhrLzQLYPlPcl4F8bijkq3S1hlVVLH1WJGlojJyNocn36Bra0XaCV O62auW0wqDdc97gXT8BH+8IatAMy2JrJX9Tlj9dknya7LOl5n+bFRToR9ahoVyQ/JmPQ z4XMTSzEG4HtM5BiI4xbHaiAbqDUf7/znTOEmpLEqtoaHhL1N/xNJ7uiH/lgcfTScDZj uyhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Zyd93s+b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h2si1220925edz.585.2020.05.01.01.42.48; Fri, 01 May 2020 01:43:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Zyd93s+b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728477AbgEAIjZ (ORCPT + 99 others); Fri, 1 May 2020 04:39:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728401AbgEAIjY (ORCPT ); Fri, 1 May 2020 04:39:24 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25B44C035494; Fri, 1 May 2020 01:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=f6i/xXj+8xtv4i22gfS0ySJPzU3clX0TdMX0edwFM/I=; b=Zyd93s+bm2ePG0jOQHcgxBCEBA 6b5dOkkiT2pXWdM71f9e6vaLLrQIkrOkBDPfj3evYLbHCDF9EES2sdwX8vKo9fBDLQ9chfKpmBb9V iYtVnGSVa9aiEZUq/+IyuYPjewHhYCpSe5+Q1wnCqjiAREX8W2gvp1hCZEUu1pV8+TxvD1e8ZM/50 3CcOHs3JR4YP/zsefvXKqPeeQl/UyiJlpVuy5zTQgHnF4PtTxM2hhA4pImy/Nvqa9qhWCI+2Nrf8O UyXf4jgzjpm5+oUUirgSJDvx4s4zWQqSRpVTVx8jNFRNA1fKitKl1vCJx+V+B0oEFsKxD/Wli57Cu iO3no+iA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jURCc-000555-Ra; Fri, 01 May 2020 08:39:22 +0000 Date: Fri, 1 May 2020 01:39:22 -0700 From: Christoph Hellwig To: ira.weiny@intel.com Cc: linux-kernel@vger.kernel.org, Andrew Morton , Christian Koenig , Huang Rui , Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Thomas Gleixner , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Andy Lutomirski , Dan Williams , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Subject: Re: [PATCH V1 05/10] arch/kmap_atomic: Consolidate duplicate code Message-ID: <20200501083922.GE27858@infradead.org> References: <20200430203845.582900-1-ira.weiny@intel.com> <20200430203845.582900-6-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430203845.582900-6-ira.weiny@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 30, 2020 at 01:38:40PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > Every arch has the same code to ensure atomic operations and a check for > !HIGHMEM page. > > Remove the duplicate code by defining a core kmap_atomic() which only > calls the arch specific kmap_atomic_high() when the page is high memory. > > Signed-off-by: Ira Weiny Looks good: Reviewed-by: Christoph Hellwig