Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp440139ybz; Fri, 1 May 2020 01:46:35 -0700 (PDT) X-Google-Smtp-Source: APiQypJezyKk3vZm/OjjshmdgnXa/AVRyGQ8f9YJWjLNakeOKDWYYa0a0qnlVATmNY8L8zucqBHH X-Received: by 2002:a17:906:2988:: with SMTP id x8mr2187643eje.16.1588322795722; Fri, 01 May 2020 01:46:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588322795; cv=none; d=google.com; s=arc-20160816; b=clJHfzHAtaTVFgKS5SofiKGTwv31dh5F/MrhLUwFCzzY2Dl+kOCHB6BQVbekZ8MFna jUCZbTZKuolldAI1zDWaMHR+Di8ZTwbQSgrwkTopsUXCWCD7iJtaJPxKhUUVTWRiQ2Ei /M8Xjy0DBw2mgQyRIDVFGOa3LmcXI+BASfL7HIzjHSqmEy9MNH3KV5FPImvgPmpsZfbX m3WqMsn4M5umkQlqZ6jtSJBl7QZiuAsxbrhHNT70g8+YxTVRkTWzUOWF7kJDi4FoRrqd UGmEvuKxUz7MynVtww9M8bvFS8FEYYbGAUJES7vB2BQihWf5zqkc3XSkdqCdyZ1ojoum zaZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=RZeiBC9EJZtL3o9wl9DzrRwokyorK8vs365JFKguCFg=; b=obIDxYA/YF4CEDIlYNDl+Tmev6ti8uSM5l/vZd91Qd1dKIxY2xTzKkJDvdSJtUHyWY V+e0FhBi0CF5X7UR44zgjqN9hPKEMice3y+q4KIGYWHN6191naAKHBhoCDMUWJSyx6RS ytwSuiCeuNw2gjtiw7wtmw6j0u8+m2QIFmpvxwO2kZcZ1jHMjLA73z9PWiySrzaEi7N6 1bYfaX5N54rpp7te1GSOf2KgMfGFGlarv6OhztLhRcklXHnzHKH7j6g/OfIUX7Lz1RP7 kRussSZvueaAHuz69Aj8uevOOVsvZ0ygxSqwnqBDFj0wyAmwmWqi2W4KuNaiGtSqHghM 2dKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=WrSjIe8B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g4si1324569ejb.192.2020.05.01.01.46.12; Fri, 01 May 2020 01:46:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=WrSjIe8B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728423AbgEAIoy (ORCPT + 99 others); Fri, 1 May 2020 04:44:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728345AbgEAIox (ORCPT ); Fri, 1 May 2020 04:44:53 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83426C035494; Fri, 1 May 2020 01:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RZeiBC9EJZtL3o9wl9DzrRwokyorK8vs365JFKguCFg=; b=WrSjIe8BMSfRLI3jpUdAEwYOJE tXYY9oHJxbcwtR63YkJacY1tOmRSo0VlWUfCBXPQ+9tbl6oJlB6VD5LcDihqELSVjdYutoJQPLF/4 8oHd/jG9oqEktRgyDMVRMOdWgUxvFWtmrO8QVY5Bwuyx4kwsw09MghtZa6r2wfdwKKLrFF/HWbKx2 Zi8C52D4aGGC5APfXtvEL4/oyOvcKOr0v4gdC7IVh3dTxxV50jGh/gnhlOpbRnTobeSX5FvfQg+XE AQYdMumCk1/McWx3/D54ShlP8u9koPQ1WhpJQpMsvcc6VEQhQ4YMiNhkqLNpVJLQbjN9J2nQBExHY I+WV6DYw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jURHq-00008h-NO; Fri, 01 May 2020 08:44:46 +0000 Date: Fri, 1 May 2020 01:44:46 -0700 From: Christoph Hellwig To: ira.weiny@intel.com Cc: linux-kernel@vger.kernel.org, Andrew Morton , Christian Koenig , Huang Rui , Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Thomas Gleixner , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Andy Lutomirski , Dan Williams , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Subject: sparc-related comment, to Re: [PATCH V1 07/10] arch/kmap: Ensure kmap_prot visibility Message-ID: <20200501084446.GG27858@infradead.org> References: <20200430203845.582900-1-ira.weiny@intel.com> <20200430203845.582900-8-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430203845.582900-8-ira.weiny@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > --- a/arch/sparc/mm/highmem.c > +++ b/arch/sparc/mm/highmem.c > @@ -33,6 +33,7 @@ > #include > > pgprot_t kmap_prot; > +EXPORT_SYMBOL(kmap_prot); Btw, I don't see why sparc needs this as a variable, as there is just a single assignment to it. If sparc is sorted out we can always make it a define, and use a define for kmap_prot that defaults to PAGE_KERNEL, avoiding a little more duplication.